Samigo notification emails need to respect user preferences and instructor preference

Description

implemented a new notification email, but the code is lacking several features:

  1. It does not seem to check if instructor wants a notification email!

  2. It does not check user preferences

  3. It does not check for valid users

  4. It sends to all members and not to just the users that can take the assessment

Attachments

1

Activity

Andrea Schmidt October 16, 2024 at 11:05 PM

Verified on 23x: https://qa23-maria.nightly.sakaiproject.org/, build: 9be7af4e

Andrea Schmidt September 9, 2024 at 10:37 PM

Verified on 25x: https://trunk-maria.nightly.sakaiproject.org/, build: 94ee9d97

The group emails are now correct also

Sam Ottenhoff September 9, 2024 at 4:18 PM

Thanks Andrea. Please test again after the commit:

 

Andrea Schmidt September 3, 2024 at 11:14 PM

Tested on 25x: https://trunk-maria.nightly.sakaiproject.org/, build: 22738a5c

When the quiz is released to the site, the emails are working as expected:

  • Regardless of student preferences, if the instructor chooses no notification, no students receive a notification regardless of the open date settings

  • If the student chooses to receive a notification and the instructor chooses to send a notification:

    • Past/now open date: email is received

    • Future open date: email is received when the open date/time has arrived

tests sheet for releasing to site:

When the quiz is released to groups, there is an issue when the instructor chooses to send a notification - no emails are received at all:

group tests sheet:

do you want a new Jira for the group issue or reopen this Jira?

Sam Ottenhoff September 3, 2024 at 7:50 PM

I’m leaning towards “two yes, one no”, that the instructor must choose to send notifications and students must choose to receive notifications, but if either one does not then no notification is sent.

 

Yes, no question, the instructor must choose the option and the student must NOT have disabled notifications in Home → Preferences

Fixed

Details

Priority

Affects versions

23 Status

Components

Assignee

Reporter

Created August 16, 2024 at 5:12 PM
Updated April 10, 2025 at 6:52 PM
Resolved September 3, 2024 at 7:49 PM