Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Portal when forming the reset urls should only effect the path of a uri

Description

When Portal is forming the reset urls for both page-reset and tool-reset it looks at the entire uri and performs string replacement, this is prone to errors.

For example give the following url:
https://tool.university.edu/portal/site/abcdef/tool/12345

The portal incorrectly create a reset url for that tool

https://tool-reset.university.edu/portal/site/abcdef/tool/12345

when it should be

https://tool.university.edu/portal/site/abcdef/tool-reset/12345

see https://www.baeldung.com/spring-uricomponentsbuilder

Activity

Show:

Andrea Schmidt June 15, 2024 at 3:48 PM

Verified on 23x: https://qa23-maria.nightly.sakaiproject.org/, build: 1a041ae0 that the nav url and reset url look the same and work from either place

Andrea Schmidt June 13, 2024 at 9:23 PM

Verified on 25x: https://trunk-maria.nightly.sakaiproject.org/, build: cc81ae9a that the nav url and reset url look the same and work from either place.

Automation for Jira June 13, 2024 at 6:02 PM

A pull request has been created, "SAK-50214 Portal when forming the reset urls should only effect the path of a uri", you can see it at https://github.com/sakaiproject/sakai/pull/12656

Fixed

Details

Priority

Affects versions

Fix versions

23 Status

QA Verification Pass

Components

Assignee

Reporter

Created June 13, 2024 at 5:53 PM
Updated June 15, 2024 at 3:48 PM
Resolved June 13, 2024 at 7:53 PM
Configure

Flag notifications