Grader: UX issues when removing and revising comments
GENERAL
TESTING
GENERAL
TESTING
Description
Activity
Show:
Andrea Schmidt June 26, 2024 at 10:44 PM
Verified on 23x: https://qa23-maria.nightly.sakaiproject.org/, build: 15132ba6 following the test plan
Sean Horner June 18, 2024 at 4:42 PMEdited
I have removed from the test plan the non-critical issues pertaining to the removal of text via the Source view of the rich text editor. Those issues are now represented by a new jira: .
With those non-critical issues aside, the test plan passes with the merged fix. I have tested the code locally. (The snapshot of code tested has as its latest commit, 9cba23810068ab445316bf87c140c2056ade9fff.
Automation for Jira June 18, 2024 at 8:46 AM
A pull request has been created, "SAK-50178 grader Show feedback and private remove links appropriately", you can see it at https://github.com/sakaiproject/sakai/pull/12668
Fixed
Details
Details
Priority
CriticalAffects versions
Fix versions
23 Status
QA Verification Pass
Components
Assignee
Adrian FishReporter
Sean HornerCreated May 30, 2024 at 11:59 PM
Updated June 26, 2024 at 10:44 PM
Resolved June 18, 2024 at 1:31 PM
The appearance of Remove links for a comment (Feedback Comment or Private Note) added is not intuitive. They seem to be added if a comment is added but only after the grading panel is closed (saved or ‘x’ clicked) and then reopened. The appearance of the ‘Remove’ link would be more intuitive if it displayed anytime its corresponding comment displays.
More importantly, after adding a Feedback Comment or Private Note, its corresponding ‘Remove’ link when clicked should display a confirmation prompt before proceeding with removing the content, similar to the confirmation for removing a rubric evaluation. Clicking this link accidentally without a confirmation prompt would lead to the frustrating experience of losing text. The lack of a confirmation modal is why I’ve marked this jira as Critical.
Also, when the comment is removed, the “Removed” notice does not disappear when editing the comment.
Finally, if removing the comment by deleting all HTML via the Source view of the CKEditor without toggling back to the WYSIWYG view before clicking Done, the edit (removal) of the comment is not saved by clicking Done. (The removal of all content via the WYSIWYG view will currently save by clicking Done, as expected.) In terms of priority, I think the last of these issues is Minor (least important/consequential).