Gradebook grade_type ordinal starts from 0 instead of 1

Description

The grade_type ordinal has changed to start from 0 to 1. This causes a couple of issues. In 22.x

1=Points and 2=Percentages

In 23.x and >:

0=Points and 1=Percentages

After upgrading, gradebooks that were using points in 22.x are now using percentages and sites that were using percentages are now getting a stack trace:

Attachments

3

Activity

Andrea Schmidt March 1, 2024 at 12:15 AM

Tested the Gradebook Calculations script on 23x: https://qa23-maria.nightly.sakaiproject.org/, build: 19b3dc26 and all calculations were correct

Andrea Schmidt February 28, 2024 at 1:49 AM

Tested the Gradebook Calculations script ( ) on 24x: https://trunk-maria.nightly.sakaiproject.org/, build: e4436b5d

All calculations were correct. Tested no categories, categories only, categories and weighting, drop highest/lowest, keep highest for points and percent. Also tested points - equal weight categories.

Charles R Severance February 15, 2024 at 7:51 PM

Thanks - that was the simple explanation I needed.

Sam Ottenhoff February 15, 2024 at 6:39 PM

From Sakai 2.0 to Sakai 22.4: 1=Points and 2=Percentages

From Sakai 23.0 until Wed Jan 24 16:33:44 2024: 0=Points and 1=Percentages

Now: 0=Unknown, 1=Points and 2=Percentages

Charles R Severance February 15, 2024 at 6:29 PM
Edited

Is it the case that

In 22.x

0=Points 1=Points and 2=Percentages

In 23.x and > after this fix:

0=Unknown, 1=Points and 2=Percentages

Ignoring for the moment how those zeros got in there in 22.x. Or correct me if I am wrong.

Fixed

Details

Priority

Affects versions

23 Status

QA Verification Pass

Components

Assignee

Reporter

Environment

23.x

Created December 19, 2023 at 5:35 PM
Updated March 1, 2024 at 12:15 AM
Resolved December 20, 2023 at 3:49 PM