Roster Card Game: Skip users with no photo

Description

Skip users with no photo, when a user does not have any photo do not include it in the game.

This can be disabled by a property. The property is called cardgame.skipNoImageUsers and is true by default.

Attachments

3
  • 02 Oct 2023, 07:57 PM
  • 02 Oct 2023, 07:57 PM
  • 01 Oct 2023, 03:26 PM

is related to

relates to

Activity

Show:

Adam Marshall October 3, 2023 at 8:57 AM

non-students didnt display at all in the game, sorry for the confusing comment. What I meant is that if you have zero students with photos but do have TA / Instructors, this is recognised and you are correctly told there are no students with photos.

Andrea Schmidt October 2, 2023 at 11:48 PM

How did you get non-students to display in Name That Face? I would think that’s a bug since everything on the page has “student” on it.

I was not able to view TAs or instructors with images, only students, and I think that is correct.

24x: https://trunk-maria.nightly.sakaiproject.org/, build: 1016fa45

Adam Marshall October 2, 2023 at 8:11 PM

works fine with multiple students / photos.Also works fine if all participants with photos are NON-students

Adam Marshall October 2, 2023 at 7:57 PM

as far as I can tell, I am able to test. Having zero students with a photo (uploaded via Profile) gives the correct message.

 

adding a rather handsome young man with a photo allows the game to operate

this on

Server Information

  • Sakai Version:  24-SNAPSHOT

  • Server Time: Oct 2, 2023 3:52:55 PM EDT

  • Server: ip-172-31-7-189

  • Build Info: 1016fa45

Andrea Schmidt October 2, 2023 at 11:33 AM
Edited

My 2 cents, QA should really be able to test this new feature. There’s no reason why the property cardgame.showOfficialPhoto=false cannot be set for some time on trunk.

Fixed

Details

Priority

Fix versions

Components

Assignee

Reporter

Labels

Created September 12, 2023 at 11:58 AM
Updated October 3, 2023 at 8:57 AM
Resolved September 26, 2023 at 9:37 AM

Flag notifications