Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Fix Typos in SakaiPlus - Including a Typo in a DB Column Name

Description

The “TENNANT_GUID” column should be named “TENANT_GUID” (one “N”)

This was noticed whilst fixing a bunch of typos in SakaiPlus identified during testing. Also a column name is incorrectly spelled in the Plus models.

this does not exactly need a conversion but it will want a clean DB on nighty - and then some way of manually fixing QA23 (perhaps drop and redo) - in my testing, I manually renamed the column in the PLUS_TENANT table and all the indexes for foreign keys got rebuilt - it might not need any manual intervetion - Hibernate is pretty smart

Attachments

11

incorporates

is depended on by

Activity

Show:

Andrea Schmidt April 17, 2023 at 11:26 PM

Verified on 23x: https://qa23-maria.nightly.sakaiproject.org/, build: 70ed2d0a that I can successfully add LTI tools

Charles R Severance December 12, 2022 at 1:47 PM
Edited

Note to self:

ALTER TABLE PLUS_TENANT CHANGE COLUMN TENNANT_GUID TENANT_GUID varchar(36) NOT NULL;

ALTER TABLE PLUS_CONTEXT CHANGE COLUMN TENNANT_GUID TENANT_GUID varchar(36) NOT NULL;

ALTER TABLE PLUS_SUBJECT CHANGE COLUMN TENNANT_GUID TENANT_GUID varchar(36) NOT NULL;

Leave “PRIMARY KEY” off the query - it stays the primary key after the rename.

Andrea Schmidt December 9, 2022 at 12:27 AM

Verified the other typos are fixed also.

Andrea Schmidt December 8, 2022 at 12:37 AM

I was able to successfully create a tenant on 24x: https://trunk-maria.nightly.sakaiproject.org/, build: 02249e62, so the db column is fixed there.

Andrea Schmidt December 8, 2022 at 12:35 AM

One typo was missed and in the process I found another one:

Fixed

Details

Priority

Fix versions

23 Status

QA Verification Pass

Components

Assignee

Reporter

Conversion Script Required

Yes
Created December 3, 2022 at 10:31 PM
Updated March 19, 2024 at 2:57 PM
Resolved December 8, 2022 at 8:24 PM