Increase Tool Order ( and Lessons and Web Content )Tool Title character limit

Description

In SAK-42262 and SAK-42261, there was a character limit of 20 placed on titles when editing tool titles in Tool Order and when creating Lessons and Web Content. Is there a particular reason for 20? Some instructors have complained that that is too short.

Longer tool titles do work:

  • when creating External Tools

  • when creating a new page via Admin -> Sites and enabling Custom Title

  • when the tool's title is hardcoded (e.g. contrib tool java code) to a longer length

Also, does the limit depend on the data type in the database's SAKAI_SITE_TOOL table's TITLE column of varchar(99)

SAK-42262 mentioned

If there are 100 + characters, the screen goes white and there is a warning in the console

if that is the limit, can the tool order, lessons, and webcontent titles be extended to 99? or something between 20 and 99?

And, would it be possible to show the limit on the Tool Order's title edit dialog?

Attachments

1

Activity

Austin August 22, 2023 at 8:35 PM

however, there is still the issue of long titles in the menu being truncated. however in , it was said that

T&L reviewed this and after some discussion, we decided that staying with the one-line, truncated titles is preferable. Truncating the titles keeps the spacing consistent in the left menu, and it also discourages users from creating long titles, which can make the page look text-heavy and cluttered.

so the patch above could be applied without doing anything with the menu titles

Austin August 22, 2023 at 8:34 PM
Edited

Here’s the patch we’ll be using (in Sakai 22)

Austin January 3, 2022 at 11:06 PM
Edited

I figured out why there is a 20 character limit on titles. If the title is too long, the menu will truncate it

In our custom install, we had modified the code that truncates the title when the menu is expanded. I discovered this while researching a separate bug where our modification was breaking the collapsed menu view of the title.

If it’s decided that titles should be 90 (or 99) characters long, the expanded vs collapsed view of the menu will also need to be updated to allow for long titles, where I think that can be fixed by changing the titles back to <span>, which was changed to <div> in 20+

see also SAK-46757

Matthew Jones January 1, 2022 at 8:59 PM
Edited

Right, this is database limited by 99. I’d agree it should be increased to match the value in the database. (Or at least increased)

It would make sense that at 100 characters there’d be an error inserting it but it can go up to that.

I also don’t know why 99 was chosen but these were from the very early days. It looks like 20 was chosen from early on back on too. Though I don’t know why it that value was initially picked there in 2011.

I’d personally vote to increase this as well, at least to match the database length, without increasing that field size. But sounds like this is configured in a few places and it was inconsistent across tools.

Details

Priority

Affects versions

Components

Assignee

Reporter

Created December 28, 2021 at 12:24 AM
Updated August 22, 2023 at 8:35 PM