Preferences tool is using the wrong property for the service name

Description

Text in the UI in the preferences tool will always display "Sakai" as the service name because the property used is incorrect. https://sakaiproject.atlassian.net/browse/SAK-25552#icft=SAK-25552 used the sakai property "ui.name" instead of the correct property "ui.service".

Attachments

2
  • 21 Feb 2022, 09:39 AM
  • 02 Dec 2021, 03:07 PM

Activity

Show:

Fernando Alvarez February 21, 2022 at 9:38 AM

Tested in my local instance.
Build: f1ddb3f
The service name now shows the ui.service value as you can see in the attached picture.

David Bauer December 2, 2021 at 4:25 PM

Yes, if it’s not set it will just display the default which is “Sakai”

Derek Ramsey December 2, 2021 at 3:07 PM

Master does not have ui.service set. If this is not set, will it still show the default text?

 

Testing this on master, I see the text: “Please select your local time zone…….”

Automation for Jira November 29, 2021 at 4:38 PM

A pull request has been created, "SAK-46612 [User] Preferences use correct property for service name", you can see it at https://github.com/sakaiproject/sakai/pull/10052

Fixed

Details

Priority

Affects versions

Fix versions

22 Status

Merged

21 Status

Merged

Components

Assignee

Reporter

Created November 29, 2021 at 4:23 PM
Updated February 22, 2022 at 2:31 PM
Resolved February 8, 2022 at 4:02 PM

Flag notifications