Kernel unit test errors for 21.x when sakai.home defined

Description

According to the 21.0 release notes for installing from source, sakai.home can (or should) be asserted to maven during the build:

mvn clean install sakai:deploy -Dmaven.tomcat.home=/pathto/tomcathome -Dsakai.home=/pathto/tomcathome/sakai -Djava.net.preferIPv4Stack=true

With the 21,x build, when I assert sakai.home, 43 NullPointer errors occur during the kernel build. A snippet from the stdout/stderr follows: 

[ERROR] Errors: [ERROR] AdvisorTest.testAdvisorOrder:44->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] DummyUserEncodingTest.setUp:46->SakaiKernelTestBase.getService:54 » NullPointer [ERROR] DummyUserEncodingTest.setUp:46->SakaiKernelTestBase.getService:54 » NullPointer [ERROR] DummyUserEncodingTest.setUp:46->SakaiKernelTestBase.getService:54 » NullPointer [ERROR] RoleProviderTest.testCheck:56->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] RoleSwapMembershipTest.testDelegatedAccess:132->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] RoleSwapMembershipTest.testRoleSwap:55->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] ContentHostingServiceRecycleTest.testDeleteResource:69->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] ContentHostingServiceRecycleTest.testDeleteResourceRestoreOnTop:141->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] ContentHostingServiceRecycleTest.testDeleteResourceTwice:97->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] ContentHostingServiceRecycleTest.testRestoreOnOverquota:177->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] ContentHostingServiceTest.testDeleteResource:205->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] ContentHostingServiceTest.testEmptyResources:73->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] ContentHostingServiceTest.testMimeDetection:233->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] ContentHostingServiceTest.testSaveRetriveFolder:106->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] ContentHostingServiceTest.testUtfFolders:168->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] RoleAccessTest.beforeClass:59->SakaiKernelTestBase.oneTimeSetup:110->SakaiKernelTestBase.oneTimeSetup:90 » BeanCreation [ERROR] RoleViewTest.beforeClass:46->SakaiKernelTestBase.oneTimeSetup:110->SakaiKernelTestBase.oneTimeSetup:90 » BeanCreation [ERROR] SiteAliasCleanupNotificationActionIntegrationTest.setUp:61->startSession:100->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] SiteServiceTest.testGroupSave:181->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] SiteServiceTest.testNonExistentSiteId:119->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] SiteServiceTest.testNullSiteId:65->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] SiteServiceTest.testPagePosition:209->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] SiteServiceTest.testRoleSwapSiteVisit:139->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] SiteServiceTest.testSiteIdWithSpaces:85->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] BasePreferencesServiceTest.setUp:65->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] BasePreferencesServiceTest.setUp:65->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] ContextualDisplayServiceTest.setUp:99->SakaiKernelTestBase.getService:63 » NullPointer [ERROR] UserDirectoryServiceGetTest.setUp:144->SakaiKernelTestBase.getService:54 » NullPointer [ERROR] UserDirectoryServiceGetTest.setUp:144->SakaiKernelTestBase.getService:54 » NullPointer [ERROR] UserDirectoryServiceGetTest.setUp:144->SakaiKernelTestBase.getService:54 » NullPointer [ERROR] UserDirectoryServiceGetTest.setUp:144->SakaiKernelTestBase.getService:54 » NullPointer [ERROR] UserDirectoryServiceGetTest.setUp:144->SakaiKernelTestBase.getService:54 » NullPointer [ERROR] UserDirectoryServiceGetTest.setUp:144->SakaiKernelTestBase.getService:54 » NullPointer [ERROR] UserDirectoryServiceGetTest.setUp:144->SakaiKernelTestBase.getService:54 » NullPointer [ERROR] UserDirectoryServiceGetTest.setUp:144->SakaiKernelTestBase.getService:54 » NullPointer [ERROR] UserDirectoryServiceGetTest.setUp:144->SakaiKernelTestBase.getService:54 » NullPointer [ERROR] UserDirectoryServiceGetTest.setUp:144->SakaiKernelTestBase.getService:54 » NullPointer [ERROR] UserDirectoryServiceGetTest.setUp:144->SakaiKernelTestBase.getService:54 » NullPointer [ERROR] UserDirectoryServiceGetTest.setUp:144->SakaiKernelTestBase.getService:54 » NullPointer [ERROR] UserDirectoryServiceGetTest.setUp:144->SakaiKernelTestBase.getService:54 » NullPointer [ERROR] UserDirectoryServiceGetTest.setUp:144->SakaiKernelTestBase.getService:54 » NullPointer [ERROR] UserDirectoryServiceGetTest.setUp:144->SakaiKernelTestBase.getService:54 » NullPointer [INFO] [ERROR] Tests run: 353, Failures: 0, Errors: 43, Skipped: 0

When sakai.home is not asserted (whether via the command line or MAVEN_OPTS, then I don't experience these unit test errors.

I've attached text files of the maven stdout/stderr for compiling just the kernel to compare asserting sakai.home (errors encountered) vs. not asserting sakai.home (no errors; unit tests pass).

 

Attachments

2
  • 20 Sep 2021, 06:10 PM
  • 20 Sep 2021, 06:10 PM

Activity

Show:

Sean Horner September 27, 2021 at 10:26 AM

Thanks, . I thought that might be the case, but.... I've since added "Release Management" and "Documentation/Reference (non-Help)" to the components of this issue. Perhaps only the latter of those two pertains.

Matthew Jones September 26, 2021 at 3:16 PM

I just think the documentation is wrong. I don't build locally with sakai.home and the nightly builds don't pass this option. It's only passed while starting up Sakai. 

Sean Horner September 20, 2021 at 6:39 PM
Edited

I'm observing similar issues with the master branch, except there are 44 instances of NullPointer errors instead of 43 like for 21.x. 

With that said, I'm omitting 22.x from the 'affected' versions at least for now, since there's no release notes for Sakai 22 re: whether or not sakai.home should be asserted during build time.

Details

Priority

Affects versions

Assignee

Reporter

Environment

mvn -version Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00) Maven home: /opt/maven/apache-maven-3.5.4 Java version: 1.8.0_111, vendor: Oracle Corporation, runtime: /opt/java/jdk1.8.0_111/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "3.10.0-1160.41.1.el7.x86_64", arch: "amd64", family: "unix"

Created September 20, 2021 at 6:10 PM
Updated September 27, 2021 at 1:47 PM