LTI Content Items (lti_content) need to have a field called the placementsecret populated with a random UUID in order for grades to flow.  The LTIService insures that this value is properly set when calling this method:

public Object insertToolContent(String id, String toolId, Properties reqProps, String siteId)

But is not set when calling these methods:

public Object insertContent(Properties newProps, String siteId)

public Object insertContentDao(Properties newProps, String siteId)

The result is entries where grades seem not to flow depending on which methods within the various code paths are used to create the content items.

While this does not fix a user-reported problem in Sakai-20 - it would be nice to back-port this bug fix in case more of the -21 code (i.e. assignments) moves back to 20.