Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Lessons has weird links like /123 in its markup

Description

Go to nightly and log in as admin and link to:

https://trunk-mysql.nightly.sakaiproject.org/portal/site/MICW_256C_7894/tool/ffd85c00-0b4b-466a-843c-8c5d5be9b273

View source and look for a line like:

<h3 class="offscreen">Section</h3>
<a role="button" href="/31" title="Join the adjacent two regions into one" class="section-merge-link" ...

Why is this a link to "nowhere"?  If the href is some kind of data it should probably be a different attribute.   If it is a URL it should be a real working URL.

As you might well guess, the smoker automated test gets kind of grumpy about these "broken" links that if followed go to a 404.

It looks life working near 'section-merge-link' most recently - but this line that seems to generate the markup is much older:

e347c045b7e (Charles Hedrick 2015-08-13 16:35:09 -0400 1335) link.decorate(new UIStyleDecorator(sectionbreak?"section-merge-link":"column-merge-link"));

Hopefully this is an easy fix and the smoker test can chill out after it is fixed.

 

 

 

Attachments

3

Activity

Thomas Kelsey April 2, 2021 at 3:22 PM

, Is there a way to set up this test circumstance without using the links in the test plan? At this point, the link no longer goes to a site.

David Bauer January 18, 2021 at 10:16 PM

Pull request made.

The item id was added to the href and needed to delete the section or column break item and merge the contents into the previous section/column. I moved the item id to a data attribute on the link and set the href to javascript:void(0);

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Labels

Created October 26, 2020 at 12:30 PM
Updated January 12, 2023 at 12:10 AM
Resolved January 26, 2021 at 11:07 AM