Message bundle manager throws error on nightly

Description

Log in as admin and go to:

https://trunk-mysql.nightly.sakaiproject.org/portal/site/!admin/tool/!admin-1575

You get the "Send Bug Report" error page and traceback as attachments.

I am guessing this is a regression and it was found by smoker.  Here is an excerpt of the trace back.

java.lang.IllegalArgumentException: max-results cannot be negative
at org.sakaiproject.portal.charon.SkinnableCharonPortal.forwardTool(SkinnableCharonPortal.java:1502)
caused by: org.springframework.web.util.NestedServletException: Request processing failed; nested exception is java.lang.IllegalArgumentException: max-results cannot be negative
at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:898)
caused by: java.lang.IllegalArgumentException: max-results cannot be negative
at org.hibernate.query.internal.AbstractProducedQuery.setMaxResults(AbstractProducedQuery.java:904)
at org.hibernate.query.internal.AbstractProducedQuery.setMaxResults(AbstractProducedQuery.java:106)
at org.sakaiproject.messagebundle.impl.MessageBundleServiceImpl.getModifiedProperties(MessageBundleServiceImpl.java:469)

Attachments

3

Activity

Andrea Schmidt February 14, 2021 at 8:48 AM

Will set this to verified. Tested both 22x: https://trunk-mysql.nightly.sakaiproject.org/, build: 26a27f9c and
21x: https://qa21-mysql.nightly.sakaiproject.org/, build: 6d202095 

There is no stack trace, but  now also affects 21x.

Andrea Schmidt November 25, 2020 at 3:40 PM

The message bundle manager is loading without an issue - no stack trace, but checking the other tabs besides the status tab and there are console errors: SAK-44716.

22x: https://trunk-mysql.nightly.sakaiproject.org/, build: 4f74a530

Bernardo Garcia Vila November 3, 2020 at 7:23 AM

I'm providing a fix for the error but I'm guessing thorough regression testing will be needed...

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Labels

Created October 25, 2020 at 9:29 AM
Updated March 23, 2021 at 10:16 AM
Resolved November 3, 2020 at 3:52 PM