RSF Tools Generate bad URLs for Static Content

Description

Some RSF tools generate some very weird links to static content.  For example go to this URL:

https://trunk-mysql.nightly.sakaiproject.org/portal/site/!admin/tool/!admin-1211/modify_email#

Watch the network tab or view the source and you will find it linking to this url:
 
https://trunk-mysql.nightly.sakaiproject.org/trunk-mysql/webapps/emailtemplateservice-tool/css/Emailtemplateservice.css
 
This path is including the local file path (see webapps) instead of the serverUrl.
 
It is somewhere deep in the RSF header magic as best I can tell.
 
This really bothers the smoker test  and it would be nice to have these positive smoker failures go away.  Perhaps even there might be real bugs from this.
 
I can give you loads of RSF pages that show this thanks to smoker.  This is just one example.

Attachments

2

Activity

Show:

Earle Nietzel October 26, 2020 at 9:53 AM

This appears to be RSF's solution of how to handle static content, i.e. bypassing portal.

Charles R Severance October 25, 2020 at 9:24 PM

I ran a full smoker on trunk and emailtemplateservice was the only one that demonstrated this behavior.

Matthew Jones October 25, 2020 at 6:56 PM

Sure, I'll mark as "Please Merge" for 20.

Matthew Jones October 25, 2020 at 6:56 PM
Edited

Took me about an hour but I think I wasted about 15 minutes testing on nightly when I thought I was on localhost.  And the rest was just going back and forth through the RSF code. There aren't any broken links now though when I run it and there were many before.

This CSS is so simple I guess nobody really noticed. 

Charles R Severance October 25, 2020 at 6:52 PM

Could we push this back to 20?  I would like to run smokers on 20.x as well to catch regressions.

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Created October 24, 2020 at 10:22 AM
Updated November 10, 2020 at 8:58 AM
Resolved October 26, 2020 at 9:54 AM