sakai-rubric-student-button is making excessive http calls on load

Description

SakaiRubricStudentButton.setHidden is making an http request for every submission when it loads, maybe should look at delaying the http call until the button is actually clicked to avoid loading data needlessly.

 

Another possible improvement maybe that only a single call is actually needed until the button is clicked since the "evaluatedItemId" is never used in the actual http call.

 

 

Attachments

1

Activity

Show:

Andrea Schmidt December 6, 2020 at 10:48 AM

Verified on 20x: https://qa20-mysql.nightly.sakaiproject.org/, build: d9edaa44
19x: https://qa19-mysql.nightly.sakaiproject.org/, build: 3a03e645

Requests look similar to the screenshot previously uploaded

Sam Ottenhoff October 16, 2020 at 6:21 PM

Those calls look okay to me. It looks like this is working well.

Andrea Schmidt October 16, 2020 at 5:34 PM

Verified that the assignments list and submissions page do not have excess calls, but once a student's name is clicked, there are many calls (without actually clicking the rubric). I have 5 students in the course (both on trunk and 21x) and both behave the same.

Should this be another Jira or is this expected once the instructor is actually in the Grader? 

21x: https://qa21-mysql.nightly.sakaiproject.org/, build: 647d982d

Derek Ramsey October 5, 2020 at 12:36 PM

Verified by Adrian.

Sam Ottenhoff October 1, 2020 at 10:01 AM

Proposed improvement sounds exactly correct to me

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Created September 30, 2020 at 11:31 PM
Updated December 6, 2020 at 10:48 AM
Resolved October 1, 2020 at 2:29 PM