Samigo - two different published assessments have identical Published Assessment URLs
Description
is related to
Activity
Austin February 5, 2022 at 12:29 AMEdited
SavePublishedSettingsListener.java processAction(ActionEvent)
FacesContext context = FacesContext.getCurrentInstance();
PublishedAssessmentSettingsBean assessmentSettings = (PublishedAssessmentSettingsBean) ContextUtil.lookupBean("publishedSettings");
assessmentSettings will have the correct assessmentID, but the wrong alias. Instead it will show the alias for the quiz in the 2nd tab.
can we lookup the alias and check if any existing alias' assignmentID (i.e. the 2nd tab's id) matches with the submitted assessmentId?
but are there other settings that are mismatched? do we check them all?
then in SavePublishedSettingsListener.java setPublishedSettings(...), the bad alias is saved to the assessment
// update ValueMap: it contains value for thh checkboxes in
// publishedSettings.jsp for: hasAvailableDate, hasDueDate,
// hasRetractDate, hasAnonymous, hasAuthenticatedUser, hasIpAddress,
// hasUsernamePassword, hasTimeAssessment,hasAutoSubmit, hasPartMetaData,
// hasQuestionMetaDataHashMap<String, String> h = assessmentSettings.getValueMap();
saveAssessmentSettings.updateMetaWithValueMap(assessment, h);again, is any other meta data being set to the wrong assessment's metadata?
but it would be best if the context didn't have the wrong / mis-matched metadata to begin with. or... further up the chain, could it detect that multiple tabas are open and not even continue saving?
Austin January 26, 2022 at 12:00 AMEdited
I found a way to reproduce this (without manually editing the database) and it involves editing two samigo tests simultaneously with two browser tabs open
see the test plan above
Also after causing the duplicate aliases, if you visit the published url, that will cause a null pointer exeption (see also SAK-45764 , which i closed as a duplicate of this)
25-Jan-2022 18:53:35.584 [33mWARN[m [http-nio-20013-exec-55] o.s.t.a.f.PublishedAssessmentFacadeQueries.getPublishedAssessmentIdByMetaLabel More than 1 assessment found with the same ALIAS = admin1643154710580, this should be unique.
25-Jan-2022 18:53:35.586 [31mERROR[m [http-nio-20013-exec-55] o.s.u.RequestFilter.doFilter
java.lang.NullPointerException: null
at org.sakaiproject.tool.assessment.ui.servlet.delivery.LoginServlet.doPost(LoginServlet.java:114) ~[classes/:?]
at org.sakaiproject.tool.assessment.ui.servlet.delivery.LoginServlet.doGet(LoginServlet.java:85) ~[classes/:?]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:655) ~[servlet-api.jar:4.0.FR]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) ~[servlet-api.jar:4.0.FR]
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227) ~[catalina.jar:9.0.54]
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162) ~[catalina.jar:9.0.54]
at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) ~[tomcat-websocket.jar:9.0.54]
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189) ~[catalina.jar:9.0.54]
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162) ~[catalina.jar:9.0.54]
at org.sakaiproject.util.RequestFilter.doFilter(RequestFilter.java:496) [sakai-kernel-api-23-SNAPSHOT.jar:23-SNAPSHOT]
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189) [catalina.jar:9.0.54]
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162) [catalina.jar:9.0.54]
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:197) [catalina.jar:9.0.54]
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97) [catalina.jar:9.0.54]
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:540) [catalina.jar:9.0.54]
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135) [catalina.jar:9.0.54]
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) [catalina.jar:9.0.54]
at org.apache.catalina.valves.RemoteIpValve.invoke(RemoteIpValve.java:769) [catalina.jar:9.0.54]
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78) [catalina.jar:9.0.54]
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:357) [catalina.jar:9.0.54]
at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:382) [tomcat-coyote.jar:9.0.54]
at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65) [tomcat-coyote.jar:9.0.54]
at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:895) [tomcat-coyote.jar:9.0.54]
at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1722) [tomcat-coyote.jar:9.0.54]
at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) [tomcat-coyote.jar:9.0.54]
at org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191) [tomcat-util.jar:9.0.54]
at org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659) [tomcat-util.jar:9.0.54]
at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [tomcat-util.jar:9.0.54]
at java.lang.Thread.run(Thread.java:829) [?:?]Austin August 12, 2021 at 9:09 PM
another possible bug as result of having duplicate ALIASes is that the ckediltor's link feature which pops up elfinder, which elfinder then will not display the duplicate alias url
Austin September 23, 2020 at 3:46 PMEdited
this sounds like or is a duplicate of SAK-43742, but does the fix in that issue
https://github.com/sakaiproject/sakai/commit/55898a3eb914aae904161729676bb27afb3654c0
merely prevent the bad link from lessons? Does it prevent the duplicate ALIAS from getting in there in the first place?
Samigo - two different published assessments have identical Published Assessment URLs
We don't know how this happened but we found it because an instructor created a Lesson page link to a Samigo T&Q quiz, but when users clicked on the link it was sending them to the wrong quiz.
We found that the Published Assessment URLs for each assessment were both set to e.g.
https://<sakai.domain>/samigo-app/servlet/Login?id=12345678-aaba-cccc-dddd-1234567890123456789012345
and checking the database, the urls are generated from the metadata "alias"
mysql> select * from sam_publishedmetadata_t where label = 'ALIAS' and assessmentid = 444444; +----------------------+--------------+-------+---------------------------------------------------+ | ASSESSMENTMETADATAID | ASSESSMENTID | LABEL | ENTRY | +----------------------+--------------+-------+---------------------------------------------------+ | 22222222 | 444444 | ALIAS | 12345678-aaba-cccc-dddd-1234567890123456789012345 | +----------------------+--------------+-------+---------------------------------------------------+ 1 row in set (0.04 sec) mysql> select * from sam_publishedmetadata_t where label = 'ALIAS' and assessmentid = 555555; +----------------------+--------------+-------+---------------------------------------------------+ | ASSESSMENTMETADATAID | ASSESSMENTID | LABEL | ENTRY | +----------------------+--------------+-------+---------------------------------------------------+ | 33333333 | 555555 | ALIAS | 12345678-aaba-cccc-dddd-1234567890123456789012345 | +----------------------+--------------+-------+---------------------------------------------------+ 1 row in set (0.02 sec)