Provide ability to add and remove favorite sites from the top bar
Description
Attachments
- 21 Oct 2019, 03:05 PM
- 21 Oct 2019, 01:47 PM
- 21 Oct 2019, 01:43 PM
- 17 Oct 2019, 02:53 PM
- 12 Oct 2019, 07:41 PM
- 11 Oct 2019, 03:06 PM
- 11 Oct 2019, 02:40 PM
- 11 Oct 2019, 02:40 PM
- 11 Oct 2019, 02:40 PM
is depended on by
Activity
Shawn Foster November 15, 2019 at 9:23 AM
Thank you for your feedback, @Sam Ottenhoff.
I have created https://sakaiproject.atlassian.net/browse/SAK-42769#icft=SAK-42769 to address the help text of your first and third points.
Sounds like you'd prefer the feature set to `portal.favoriteSitesBar.showFavStarsOnAllSites=false` so the star to only appears on the current site.
Sam Ottenhoff November 12, 2019 at 9:18 AM
My first use of this feature as a decade-long Sakai user:
Hover over star to figure out what it does: no hover help text
Why is it important to un-favorite my already-favorited sites? E.g., why so much screen real-estate to perform a little-used function?
Go to a site that is not a favorite, okay it makes sense to easily favorite this one. But no hover text to help me know what the star does.
Shawn Foster October 31, 2019 at 4:38 PM
I've added two new sakai.properties to my PR for this contribution:
# SAK-42642 - Display stars for favorite sites beside their site titles in the top bar
# DEFAULT: true
# portal.favoriteSitesBar.showFavoriteStars=false
# SAK-42642 - Display stars on all sites (true) or only on the current site (false)
# Requires "portal.favoriteSitesBar.showFavoriteStars" to be enabled above first
# DEFAULT: true
# portal.favoriteSitesBar.showFavStarsOnAllSites=falseThe first one toggles the stars in top bar. The second one toggles between displaying the stars on all site tabs or on only the current site.
Tiffany Stull October 21, 2019 at 3:06 PMEdited
Right, I'm suggesting that the solid/outline star appears in the site you are currently in, but not the other site tabs.
It seems to me that it is most relevant for the currently active site, and this would match the behavior I find in an internet browser. When I'm viewing a page in Chrome, I can select the star in the address bar to bookmark (or remove a bookmark for) the current page. However, tabs for the other pages in my bookmarks bar, which I can select to access those pages, don't have stars visible to un-favorite them.
Adam P October 21, 2019 at 3:00 PMEdited
I think I might have misunderstood your suggestion. So the solid/outline star only appears in the site you are currently in and the star does not disappear when clicked?
To make it easier to add and remove sites that appear across the top as you are using a particular site, we'll add the stars to the sites to allow you to "pin" the site in-place to the top nav bar and make it a favourite site immediately. The same process can be used to remove a site.
This is similar functionality to how bookmarking works in browsers these days.
This functionality doesn't require any page refresh because the star changes from an outline to a full star (like in the Sites drawer) when you click on it and the update is made via a webservice call.