Create and Edit User Details forms' Save and Update Details button are always greyed out when password fields are hidden/not rendered (via custom code)

Description

I'm not sure if this is a valid issue because this depends on custom code we use to prevent the password fields in the Create User and Edit User details form from being rendered if the user logged via single sign on (ldap) because we don't those users changing their password through sakai.

However, looking at the code in userEditValidation.js, perhaps this was something other institutions may have also done in the past

Notice that is says "If there's a password field"

But then later in the code, regardless of whether or not there's a password field it tries to validate that the passwords match. And the matching must be run even if there's no password field because I believe there's another form validation check later on that will fail if the password matching hasn't been validated (again, even if there's no password field)

But between 11.x and 12.0, there was a change in userEditValidation.js ( Merge velocity admin tools together)

So now, because we don't render the password fields, the passwords will never match and the Save or Update details buttons are always greyed out

I'm not sure, but this might also happen if USER.isPasswordPolicyEnabled = false, but I tried reviewing the code that sets that, but it was a bit confusing.

Attachments

1

Activity

Show:

Matthew Jones June 25, 2018 at 1:44 PM
Edited

Looks like there was some "fix" submitted for this against but that is going to need to be reverted and reworked. I feel like this one should be closed as a duplicate.

Austin June 20, 2018 at 2:42 PM

Since we're using custom code to disable the password field, perhaps this JIRA is not a valid use case? But since a change in the core Sakai code broke our code I though I could be useful to report it in case other institutions might be doing something similar. If this isn't a valid case, that's OK, we'll continue to make custom modifications to make it work again.

Duplicate

Details

Priority

Components

Assignee

Reporter

Created June 20, 2018 at 2:29 PM
Updated June 25, 2018 at 1:45 PM
Resolved June 25, 2018 at 1:45 PM