Currently LinkMigrationHelper doesn't have any JavaDoc, generics or tests. This makes it very difficult to understand what the code should be doing without going and reading the implementation.
This adds some JavaDoc and tests to LinkMigrationHelper. It also removes the static cover to make testing easier with the injected serverconfigurationservice. (Revision 306141)
Result = UNSTABLE
Matthew Buckett February 18, 2014 at 11:15 AM
Cheers for review.
Matthew Buckett February 18, 2014 at 11:12 AM
Trunk built fine with patch.
So applied with a couple of tiny changes.
Sam Ottenhoff February 18, 2014 at 9:56 AM
The addition of a test is great. I think if you can confirm that this doesn't break the build, okay to commit.
Currently LinkMigrationHelper doesn't have any JavaDoc, generics or tests. This makes it very difficult to understand what the code should be doing without going and reading the implementation.