Have the kernel deploy the JSTL jar to $CATALINA_HOME/shared-lib

Description

Currently we have a pom that deploys the jstl jar to shared/lib

https://source.sakaiproject.org/svn/sakai/trunk/jstl-shared-deploy/pom.xml

I think we should eliminate this pom and simply have the kernel deploy the jstl jar to shared/lib. I recognize it violates best practice regarding dependency management (i.e., including dependency declarations not required by a project should be avoided) but I think it an acceptable exception in this case.

Rationale

1. Arguably, jstl should never have been deployed to shared/lib and instead been bundled up with the tools that need it, but Aaron notes that no doubt contrib tools have come to rely on it in shared/lib so getting it out (an easy task for core tools) is I think a non-starter.

2. Having the JSF project deploy it to shared/lib while meeting a necessary condition for JSF tools fails the sufficiency test since the JSP tag lib can both be employed in a non-JSF context and is required by certain builds such as -Pcafe and -Pframework (does anyone actually use this build any more?) that exclude the Sakai JSF project.

3. The kernel deploys a number of jars to shared/lib such as spring-webmvc that it is not dependent upon. I assume in such cases convenience trumps the purity inherent in best practice. Whatever the case, I think having the kernel deploy jstl a defensible exception.

Core projects with a jstl dependency: gradebook, help, jobscheduler, jsf, metaobj, osp, rwiki, samigo, sections, tool, user.

4. Streamlining our build process and eliminating poms where it makes sense is a good thing.

The jstl dependency would be added to both the kernel assembly and shared poms.

<dependency>
<groupId>javax.servlet</groupId>
<artifactId>jstl</artifactId>
<version>1.1.2</version>
<scope>compile</scope>
</dependency>

Environment

None

Test Plan

None

Activity

Show:

Matthew Jones April 24, 2018 at 10:34 AM

Bulk closing issues that have not been updated since 2015 and earlier. Please reopen if this is still an issue and you have new information or if this is a feature you'd like to still have consideration for.

David Horwitz August 9, 2011 at 12:44 AM

now that spring-webmvc is no longer in shared this may be a non issue ...

Won't Fix

Details

Assignee

Reporter

Components

Affects versions

Priority

Created May 16, 2011 at 7:28 AM
Updated April 25, 2018 at 3:34 PM
Resolved April 24, 2018 at 10:34 AM