MBeanExporter JMX beans not being initialized

Description

We used to have some beans in org.sakaiproject.org but after Sakai 11 they are no longer present. Doing some research I saw Spring 4.1 has a SmartInitializingSingleton and since we are overriding the Default Bean Factory the method for afterSingletonsInstantated isn't being called.

http://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/beans/factory/SmartInitializingSingleton.html

The code right from this method looks like it's going to be enough, testing locally it looks good. Might affect anything else that runs at level.

NoiserDefaultListableBeanFactory not calling afterSingletonsInstantiated

Attachments

1

Activity

Show:

Sam Ottenhoff August 22, 2016 at 9:34 AM

Tested locally again, this is working well. Thanks.

Matthew Jones August 19, 2016 at 6:50 PM

Looking at this, I actually feel like changing the default log level of org.springframework to INFO might be a good idea. There's some useful messages in there and it doesn't add a lot ton of noise.

Matthew Jones August 19, 2016 at 6:47 PM

Marking as verified based on seeing them in VisualVM

When I increase the log level of org.springframework to INFO I see about 40 seconds after startup (but still 20 seconds after fully started). Thanks!

Matthew Jones August 19, 2016 at 6:16 PM
Edited

I did a full rebuild of master and I'm seeing both the org.sakaiproject.Sessons and org.sakaiproject.sitestats.api.StatsUpdateManager.

Were there more that were there? I saw some commented out of the xml.

Attached an image from VisualVM connected to local tomcat (full clean rebuild from 57d355b833c0dc801a6e6f7354ad1bbbc9cce5a4)

Sam Ottenhoff August 19, 2016 at 4:55 PM

This isn't working for me on my local DEV. Still not seeing the old Sakai JMX beans.

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Created August 17, 2016 at 4:47 PM
Updated April 25, 2018 at 3:20 PM
Resolved August 19, 2016 at 3:41 PM