Strings used to define settings in properties files do not fully expand for use in other files

Description

Previously, one could define settings in one *.properties files and be able to use those settingsin any other *.properties file. The most common example is to define passwords or other "sensitive" data in security.properties:

columbia_sakaidb_password=NOTAPASSWORD
columbia_otherdb_password=NOTADIFFERENTPASSWORD

and then use those definitions in other settings in sakai.properties:

password@javax.sql.BaseDataSource=${columbia_sakaidb_password}
db_pw=${columbia_otherdb_password}

The definitions-- no matter which *.properties file they are in – were fully expanded to use the originally-defined values. This isn't the case anymore

The problem appears to specifically affect string expansion in "simple" configuration settings, but not in "bean-style" ones. To use the above example, this setting:

password@javax.sql.BaseDataSource=${columbia_sakaidb_password}

fully expands to use the value of "${columbia_sakaidb_password}" while this setting:

db_pw=${columbia_prometheus_otherdb_password}

does NOT expand, leaving it with the string name as its value (i.e., "${columbia_otherdb_password}") instead of the actual value.

Attachments

2

Activity

Show:

Aaron Zeckoski August 24, 2012 at 11:39 AM

tested and merged

Seth Theriault May 18, 2012 at 4:08 AM

The update to the default config appears to have been done in r108251.

Seth Theriault May 17, 2012 at 12:31 PM

Removing 1.2 "Affects Version" based on e-mail discussion. In essence, 2.8/1.2 are not affected.

Hudson CI Server May 17, 2012 at 12:27 PM

Integrated in kernel-trunk #511 (See http://builds.sakaiproject.org:8080/job/kernel-trunk/511/)
removing extra log lines (Revision 108256)

Result = SUCCESS

Gregory Thomas May 17, 2012 at 12:21 PM

r108258 - 1.3.x merge again. I missed the 2nd commit with removing some logging

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Property addition/change required

Yes

Created May 6, 2012 at 5:48 AM
Updated April 25, 2018 at 3:20 PM
Resolved May 17, 2012 at 11:10 AM