Add support for bind vars in dbdoublestorage

Description

See for patch file

Attachments

3

Activity

Show:

Hudson CI Server February 28, 2013 at 10:16 AM

Integrated in kernel-trunk #601 (See http://builds.sakaiproject.org:8080/job/kernel-trunk/601/)
Reapplied String -> Object change from Matthew B after CLE team discussion (Revision 120521)

Result = SUCCESS

Aaron Zeckoski February 28, 2013 at 9:12 AM

Reapplied String -> Object change from Matthew B

Jonathan Cook February 28, 2013 at 8:23 AM

Using List <Object> makes sense. The end result from our perspective will be the same, to 'stabilize' the Oracle explain plan for the calendar_event query. Honestly when I made the adjustment to allow for bind variables, BasicSqlService looked like it converted to Strings in any case, but now I see the type check in prepareStatement method. I adjusted IU code to use Object and initial testing with Oracle looks good. So if that's the way you want to go in kernel, I don't think it breaks anything here at IU.

Matthew Buckett February 27, 2013 at 4:50 AM

Needs Integers to be passed through for MySQL.

Aaron Zeckoski February 26, 2013 at 3:27 PM

"then all the values in the prepared statement are set using org.sakaiproject.db.impl.SqlServiceSql.setBytes(PreparedStatement, String, int) which causes the range selectors to fail."
I believe this code was already being run in production at IU but will discuss it with them at the next CLE team call and see what they say about this.
I don't want to break something that has been working for them.

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Created February 21, 2013 at 7:54 AM
Updated April 25, 2018 at 3:18 PM
Resolved February 28, 2013 at 9:14 AM