Lessonbuilder saves the placement every time the page changes.

Description

In org.sakaiproject.lessonbuildertool.tool.beans.SimplePageBean#submit() the tool gets the current placement and uses this to decide how filtering should be done (just reads). But then at the end it saves the placement that is hasn't changed.

This doesn't save the whole site, just the placement, however this does cause a site update event to be fired and I think this causes the site to be flushed from the cache.

I haven't fully debugged this but from a reading of the code it seems there's no reason to save the placement and this stops the site getting flushed from the cache.

Activity

Show:

Adam Marshall October 13, 2016 at 5:19 AM

verified as I understand that Matthew fixed it

Charles Hedrick September 7, 2016 at 12:04 PM

I'm moving this into 11.x without further testing. there's no practical way a user can see whether placement was saved. The line of code was simply unnecessary

Charles Hedrick September 7, 2016 at 12:03 PM

The same issue exists going back to version 1.0 of lessons. As far as I can tell this statement was never needed.

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Created September 7, 2016 at 8:43 AM
Updated April 18, 2018 at 7:30 AM
Resolved September 7, 2016 at 12:02 PM