File names not mentioned after uploading the files either in 'Embed content on page' or 'Add content link' dialog box

Description

1. Login as Instructor, Select one of test site, click on Lessons
2. Click on 'Add Content' -> 'Add Content Links'
3. Click on 'Choose files'
4. Select more than one file at a time and click 'Open' in Windows/ click 'Choose' on MacBook to upload the files.
(Note: The 'Add Content+' -> 'Embed content on page' also fails)

Problem:
The number of files selected appear next to 'Upload' button. But names of the file we selected aren't displayed in the screen which creates a confusion. Also, there is no Remove option once you have selected the file.

https://www.evernote.com/l/ATlvHtWPmh1Et6bCOKGf2b0RQlY6OYlPn_4
https://www.evernote.com/l/ATm2f9Ah1ldLkLWffiP50hQiMlM60HgXKvE

Activity

Show:

Surya Kiran Akula September 21, 2016 at 1:53 PM

tested on nightly trunk,
it looks good.

http://www.evernote.com/shard/s606/sh/b7026c56-5243-401e-9e64-d4cfbfd93c69/0d3f69d48306bac158bf60267950997d

Build Info:
Sakai - f1eaab3 - Sakai f1eaab338e333da46bc4ec8d0f4d0e3416e624a2 - Server ip-172-31-6-159

Neal Caidin August 24, 2016 at 1:22 PM

Looks like this is in the 11.x branch so I've set 11 status to Resolved.

Charles Hedrick June 16, 2016 at 11:37 AM
Edited

I'm showing no merge status for 10 or 11. This isn't a bug fix, exactly, but it is a definite improvement in the UI. My concern is that the same dialog is used in something like 6 contexts, and there are lots of paths through the code. Testing is going to be a bear. So I think this may be a bit late for 11. On the other hand, without this, there are some loose ends with the patch adding item names to the file chooser. That was put into 10 even though it might not have been quite ready. So maybe this patch should go into 10 and 11.

Charles Hedrick June 15, 2016 at 10:33 AM

I'm redoing the UI so you get a list of files chosen, with red X to let you remove one.

There's going to be a price for this. I'm disabling the ability to choose more than one file at a time. You can choose one and then choose another. But you can't open the browser's pick window and pick two adjacent files at once.

The problem is that Javascript doesn't let you remove one file from the list of files chosen. You can probably get away with it, but it's specifically documented as prohibited. I don't want to write code that does things you're not supposed to do, because it's liable to break the next time the browser vendors decide to tighten security.

I think overall it's a much more usable UI, but there will that loss.

Charles Hedrick June 14, 2016 at 12:36 PM

At least with Safari, multiple files work fine. I need to put some work into the UI to reflect that.

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Environment

OS: MacBook Pro OS X Maverics Version 10.9.4; Browser: Safari 7.0.5 OS: Windows 10; Browser: Chrome QA01 server also QA test server on MySql Sakai 11.0-RC01

Created June 13, 2016 at 9:35 AM
Updated April 18, 2018 at 7:30 AM
Resolved June 16, 2016 at 11:34 AM

Flag notifications