Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

improve auto created folders for uploaded files

Description

When files are uploaded, we create a folder. Make the following improvements:

  • folders are in a hierarchy matching the page hierarchy

  • there is one folder per page

  • if the page is renamed we keep using the same folder, so that there's just one folder per page. The folder name is remembered as an attribute of the page.

  • folder names are limited to 30 characters, to allow for a fairly deep hierarchy

  • folder names are always unique. The -1, -2 approach is used to avoid duplication.

  • If the length of a folder name would be too close to the limit, just use the name of the page

  • limit file names to 30 characters

For long names, truncation is done in the middle.

Note that existing files will be left where they are, to avoid breaking links.

A field is added to lesson_builder_pages. If auto.ddl is on everything will work automatically. folder varchar(250).

Activity

Show:

Charles Hedrick July 26, 2016 at 10:22 AM

Yes it is. I had added it to the conversion script, but the official verdict is that we expect people to do all the 10.x scripts before the 11 script, so having it a second time in the 11 script could generate errors.

David Bauer July 26, 2016 at 10:06 AM

Is the work from this ticket included in 11.0?

If so, the conversion scripts for this could be missed by someone upgrading from a previous version to 11.0. There is no 10.7 to 10.8 conversion script file on the 11.x branch or in the 11.0 tag. It's only in master. So, someone upgrading from 2.9.3, for example, may not realize that there is a 10.7 to 10.8 conversion script file missing if they've simple checked out the 11.0 tag.

Oracle example:
https://github.com/sakaiproject/sakai/blob/master/reference/docs/conversion/sakai_10_7-10_8_oracle_conversion.sql - Exists

https://github.com/sakaiproject/sakai/blob/11.x/reference/docs/conversion/sakai_10_7-10_8_oracle_conversion.sql - Not found
https://github.com/sakaiproject/sakai/tree/11.0/reference/docs/conversion/sakai_10_7-10_8_oracle_conversion.sql - Not found

Perhaps something in Confluence would be enough? https://confluence.sakaiproject.org/display/DOC/Sakai+11+upgrade+information

Charles Hedrick July 21, 2016 at 8:17 AM

I've done a PR.

Matthew Buckett July 21, 2016 at 2:11 AM

The changes that went into the 11.x upgrade scripts for this Jira should be backed out I believe as the normal recommendation when upgrading Sakai is to run all the upgrade scripts from the version you're currently at to the version you're upgrading to. Therefore anyone is upgrading to 11.x should have already run the 10.8 upgrade script before running the 11.0 one and so should already have the DB changes from this issue.

Sam Ottenhoff May 19, 2016 at 12:29 PM

We need a 10.8 conversion script .....

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Conversion Script Required

Yes

Created June 16, 2015 at 1:17 PM
Updated April 18, 2018 at 7:30 AM
Resolved June 16, 2015 at 1:21 PM

Flag notifications