Samigo POST without redirect change (SAM-2378) causes regressions

Description

In testing SAM-2378, there were a regression(s) that this caused. It either should be reverted or fixed

- Samigo error messages are not displayed. Because of the immediate redirect, the user doesn't get to see the error message from form POSTS.

is depended on by

is related to

Activity

Show:

Molly Kelsey March 28, 2016 at 8:48 AM

https://trunk-mysql.nightly.sakaiproject.org/portal/
OS X Yosemite v10.10.5
Safari v9.1 (10601.5.17.4)

Error message displayed, all good.

https://www.evernote.com/l/AstCeBR8n2ZAar4BmTZn1mf9U4voDuye9p4

Matthew Jones March 24, 2016 at 12:10 PM

The easiest way to verify this would be to verify is fixed.

Trisha Gordon March 24, 2016 at 12:04 PM

Earle, how can one test/verify this fix?

Earle Nietzel March 21, 2016 at 12:37 PM

The idea of switching all the pages that perform a POST to do a POST+REDIRECT is a good idea however in JSF1.x there is no support for request params that should be available after the a REDIRECT in the GET. Typically params that are needed in the GET from a PRG are those that potentially convey the status of the POST like success or an error message. In JSF 2.0+ there is such params called flash params. Spring MVC also has an identical notion of flash params.

While there are potential ideas to implement our own flash parameters it would make more sense to wait knowing that a newer version of JSF (>=2.0) has support for flash parameters. In doing so we can implement these changes in a way that is copacetic with the JSF framework vs implementing a one off solution.

JSF Flash https://javaserverfaces.java.net/docs/2.0/javadocs/javax/faces/context/Flash.html
Spring Flash http://docs.spring.io/spring/docs/current/spring-framework-reference/html/mvc.html#mvc-flash-attributes

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Created March 19, 2016 at 10:46 AM
Updated April 17, 2018 at 8:39 AM
Resolved March 22, 2016 at 11:03 AM