edit settings fails if there are multiple groups with the same name
Description
is related to
Activity
Hudson CI Server March 11, 2014 at 8:39 PM
Integrated in sakai-trunk-java-1.7 #26 (See http://builds.sakaiproject.org:8080/job/sakai-trunk-java-1.7/26/)
SAM-1010: edit settings fails if there are multiple groups with the same name (Revision 307016)
Result = SUCCESS
Hui Tsao March 11, 2014 at 5:36 PM
Thanks Matthew. I have committed the fix in trunk (r307016).
Matthew Jones October 3, 2013 at 2:39 PM
This problem is still an issue on trunk nightly.
To reproduce easily:
Create a site
Go to Site Info-Manage Groups. The regular workflow doesn't let you create groups with the same title, but Auto Groups does.
Use Auto Groups to create groups with the same role twice.
Then go into Assessments, create one and click on settings. This stack trace comes up.
I didn't actually see any commits for this in the commit tab?
The fact that Auto Groups creates groups with the same title seems like a bug too though, but I'm sure there's other ways to do it.
Hui Tsao July 13, 2011 at 1:49 PM
Fixed in r95139.
Will Humphries July 13, 2011 at 7:03 AM
See my comment on https://sakaiproject.atlassian.net/browse/SAM-805#icft=SAM-805 - some of that fix was not merged to 2.7.
We got a backtrace when doing "setings" or "publish" for any assessment in a site. It turns out the problem is that there are two groups with the same name. This appears to confuse the JSF control.
org.sakaiproject.portal.api.PortalHandlerException: org.sakaiproject.tool.api.ToolException: javax.servlet.jsp.JspException: null
at org.sakaiproject.portal.charon.handlers.ToolHandler.doPost(ToolHandler.java:73)
caused by: org.sakaiproject.tool.api.ToolException: javax.servlet.jsp.JspException: null
at org.sakaiproject.portal.charon.SkinnableCharonPortal.forwardTool(SkinnableCharonPortal.java:1216)
caused by: org.apache.jasper.JasperException: javax.servlet.jsp.JspException: null
at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:377)
caused by: javax.servlet.ServletException: javax.servlet.jsp.JspException: null
at org.apache.jasper.runtime.PageContextImpl.handlePageException(PageContextImpl.java:776)
caused by: java.lang.NullPointerException
at com.sun.faces.renderkit.html_basic.SelectManyCheckboxListRenderer.renderOption(SelectManyCheckboxListRenderer.java:179)
at com.sun.faces.renderkit.html_basic.SelectManyCheckboxListRenderer.encodeEnd(SelectManyCheckboxListRenderer.java:156)
at javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:720)
at javax.faces.webapp.UIComponentTag.encodeEnd(UIComponentTag.java:623)
at javax.faces.webapp.UIComponentTag.doEndTag(UIComponentTag.java:546)
at com.sun.faces.taglib.html_basic.SelectManyCheckboxTag.doEndTag(SelectManyCheckboxTag.java:534)
at org.apache.jsp.jsf.author.authorSettings_jsp._jspx_meth_h_selectManyCheckbox_0(authorSettings_jsp.java:3986)
at org.apache.jsp.jsf.author.authorSettings_jsp._jspx_meth_samigo_hideDivision_3(authorSettings_jsp.java:3704)
at org.apache.jsp.jsf.author.authorSettings_jsp._jspx_meth_h_form_0(authorSettings_jsp.java:803)
at org.apache.jsp.jsf.author.authorSettings_jsp._jspService(authorSettings_jsp.java:591)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:334)
at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:314)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:264)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)