NPE from ItemContentsBean

Description

Seen in production logs unknown cause and effect

java.lang.NullPointerException
at org.sakaiproject.tool.assessment.ui.bean.delivery.ItemContentsBean.getResponseTextForDisplay(ItemContentsBean.java:785)
at sun.reflect.GeneratedMethodAccessor18099.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at com.sun.faces.el.PropertyResolverImpl.getValue(PropertyResolverImpl.java:79)
at com.sun.faces.el.impl.ArraySuffix.evaluate(ArraySuffix.java:167)
at com.sun.faces.el.impl.ComplexValue.evaluate(ComplexValue.java:151)
at com.sun.faces.el.impl.ExpressionEvaluatorImpl.evaluate(ExpressionEvaluatorImpl.java:243)
at com.sun.faces.el.ValueBindingImpl.getValue(ValueBindingImpl.java:173)
at com.sun.faces.el.ValueBindingImpl.getValue(ValueBindingImpl.java:154)
at javax.faces.component.UIOutput.getValue(UIOutput.java:147)
at com.sun.faces.renderkit.html_basic.HtmlBasicInputRenderer.getValue(HtmlBasicInputRenderer.java:82)
at com.sun.faces.renderkit.html_basic.HtmlBasicRenderer.getCurrentValue(HtmlBasicRenderer.java:191)
at com.sun.faces.renderkit.html_basic.HtmlBasicRenderer.encodeEnd(HtmlBasicRenderer.java:169)
at javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:720)
at com.sun.faces.renderkit.html_basic.HtmlBasicRenderer.encodeRecursive(HtmlBasicRenderer.java:443)
at com.sun.faces.renderkit.html_basic.HtmlBasicRenderer.encodeRecursive(HtmlBasicRenderer.java:440)
at com.sun.faces.renderkit.html_basic.GroupRenderer.encodeChildren(GroupRenderer.java:130)
at javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:701)
at com.sun.faces.renderkit.html_basic.HtmlBasicRenderer.encodeRecursive(HtmlBasicRenderer.java:435)
at com.sun.faces.renderkit.html_basic.TableRenderer.encodeChildren(TableRenderer.java:257)
at javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:701)
at com.sun.faces.renderkit.html_basic.HtmlBasicRenderer.encodeRecursive(HtmlBasicRenderer.java:435)
at com.sun.faces.renderkit.html_basic.TableRenderer.encodeChildren(TableRenderer.java:257)
at javax.faces.component.UIComponentBase.encodeChildren(UIComponentBase.java:701)
at javax.faces.webapp.UIComponentTag.encodeChildren(UIComponentTag.java:607)
at javax.faces.webapp.UIComponentTag.doEndTag(UIComponentTag.java:544)
at com.sun.faces.taglib.html_basic.DataTableTag.doEndTag(DataTableTag.java:491)
at org.apache.jsp.jsf.evaluation.gradeStudentResult_jsp._jspx_meth_h_005fdataTable_005f2(gradeStudentResult_jsp.java:2246)
at org.apache.jsp.jsf.evaluation.gradeStudentResult_jsp._jspx_meth_h_005fform_005f0(gradeStudentResult_jsp.java:593)
at org.apache.jsp.jsf.evaluation.gradeStudentResult_jsp._jspService(gradeStudentResult_jsp.java:388)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:369)
at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:308)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:259)

Attachments

1

Activity

Show:

Hui Tsao May 1, 2012 at 10:40 AM

Done. r107743 in 2.8.x.

David Horwitz April 5, 2012 at 12:52 AM

Looks like the patch has been committed - maybe the call just needs to be resolved and merged?

Sam Ottenhoff April 4, 2012 at 11:41 AM

I continue to see this NPE on lots of 2.8.x instances. The patch seems quite safe. Can someone take a look please?

Sam Ottenhoff September 20, 2011 at 10:43 AM

Hi Samigo Team.

Possible steps to replicate:

1) Use autosubmit to submit several student responses

2) Attempt to grade individual student responses from the auto-submitted assessment (where the student response will be null)

This patch seems safe and smart.

David Roldán Martínez June 15, 2011 at 9:11 PM

Patch for trunk. It follows David H. recommendations and checks if null before to replace.

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Property addition/change required

Yes
Created March 29, 2011 at 5:10 AM
Updated April 17, 2018 at 8:38 AM
Resolved May 1, 2012 at 10:40 AM