Can generate DB error through entitybroker /direct/sam_pub

Description

Samigo is registered under the URL in entity broker /direct/sam_pub. If an anonymous user hits a URL such as /sam_pub/1.txt then a 500 error is returned and in the logs we get

WARN Direct request failure: RuntimeException:org.springframework.orm.hibernate3.HibernateObjectRetrievalFailureException: No row with the given identifier exists: [org.sakaiproject.tool.assessment.data.dao.assessment.PublishedAssessmentData#3]; nested exception is org.hibernate.ObjectNotFoundException: No row with the given identifier exists: [org.sakaiproject.tool.assessment.data.dao.assessment.PublishedAssessmentData#3]:Direct request failure: RuntimeException:org.springframework.orm.hibernate3.HibernateObjectRetrievalFailureException: No row with the given identifier exists: [org.sakaiproject.tool.assessment.data.dao.assessment.PublishedAssessmentData#3]; nested exception is org.hibernate.ObjectNotFoundException: No row with the given identifier exists: [org.sakaiproject.tool.assessment.data.dao.assessment.PublishedAssessmentData#3]

The users rights should be checked before hitting the DB. Please verify that this is intended behavior nd that no resources are lossed on Exception

Activity

Show:

Hudson CI Server November 15, 2010 at 12:21 PM

amberg1 November 4, 2010 at 2:25 AM

Confirmed for 2.8 alpha 3

amberg1 September 21, 2010 at 12:06 AM

Confirmed against nightly
http://nightly2.sakaiproject.org:8082/direct/sam_pub/3.txt
Please don't make me revisit this too often.

amberg1 September 21, 2010 at 12:03 AM

An anonymous user can create a DB error. It is a critical bug.
Please review and either close or repair

Lydia Li March 26, 2010 at 11:23 AM

Btw, Joshua said "The ticket requests that "The users rights should be checked before hitting the DB", but we support anonymous assessments and we can't tell if the assessment allows anon access until we fetch it from the db."
He's going to look into perhaps catching the exception and print out some more meaningful msg.

I do not think this is a critical bug though.

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Environment

qa1-nl Sakai 2.7.b2
Created February 11, 2010 at 4:05 AM
Updated April 17, 2018 at 8:32 AM
Resolved November 15, 2010 at 12:03 PM