HistogramListener.histgramScores can fail silently
GENERAL
TESTING
GENERAL
TESTING
Description
is related to
Activity
Show:
David Horwitz April 7, 2010 at 2:07 AM
Hi Lydia,
I saw it while tying to figure out the problem in I see this on 2 assessments on one site. Both seem to have no submissions. Lookign at the code there are 2 places it could silently return false causing a runtime error with no diagnostic information. This should be fixed anyway irespective of the root cause of the error
Lydia Li April 6, 2010 at 11:25 AM
Does this assessment have any submissions? or does it not have any submissions like SAK-18333?
Also, does this happen to all assessments in this site, or does it only happen to one assessment?
We hit this in production: clicking on the statistics link led to a stacktrace like this:
2010-04-06 14:59:00,932 ERROR TP-Processor1389 com.sun.faces.lifecycle.ApplyRequestValuesPhase - failed to call histogramScores.
java.lang.RuntimeException: failed to call histogramScores.
at org.sakaiproject.tool.assessment.ui.listener.evaluation.HistogramListener.processAction(HistogramListener.java:102)
at javax.faces.event.ActionEvent.processListener(ActionEvent.java:57)
at javax.faces.component.UIComponentBase.broadcast(UIComponentBase.java:649)
at javax.faces.component.UICommand.broadcast(UICommand.java:297)
The route cause is HistogramListener.histogramScores returning false which causes a RuntimeException to be throws. In this case the logs are devoid of any informative output as to the cause which makes trouble shooting near impossible. histogramListener should at the lease log at warn or error level the details of any call that will cause it to return false