samigo, gradebook: Published Copies doesn't give user a message on attempting to save GB setting if existing item blocks send to GB
GENERAL
TESTING
GENERAL
TESTING
Description
Issue:Published Copies does not properly check for conflicting gradebook items on Save. If the gradebook has an existing item with the same name as an already-published quiz, and the user modifies quiz settings in Published Copies to enable Send to gradebook, the save completes but the item cannot be sent to the gradebook. The user does not get any warning of this - it's a silent failure. Several instructors at UVA have encountered this issue recently - they don't understand why their quiz grades do not appear in the gradebook after saving the setting to send to gradebook.
In Working Copies, if you try to publish a quiz with the setting Send to gradebook and there is a conflicting gradebook entry, the following error message is displayed instead of publishing:
Another item with the same title exists in Gradebook. Please choose another title.
This should be fixed so the correct error also displays for users on the Published Copies tab.
It appears a new issue has resulted from this change. Now in Sakai 12, if you attempt to edit settings on any published quiz that is already being sent to the Gradebook, when you click Save, the error is thrown and the save blocked. To reproduce:
In a site with Gradebook and Samigo, create a quiz with at least one question.
Go to _Settings_ > *Grading and Feedback* and select *Send assessment score to Gradebook immediately*.
Publish the quiz.
Go to *Published Copies*, select *Settings* for the quiz.
Make any change to settings (e.g. change the due date), then *Save*. Instead of saving settings, the error is thrown.
The workaround to force the settings change to save is to edit the *Grading and Feedback* setting at the same time as your other settings change so you do NOT send to GB. Then edit the settings again to send to GB again.
Matthew Jones April 16, 2018 at 4:47 PM
I feel like this is causing because of the commit on below removing isTitleChanged from the if case is causing this new issue.
commit 95340f313f88e1ed4d72e7b23d5aae448b96bffc Author: Brian Jones <bjones86@uwo.ca> AuthorDate: Thu Mar 8 18:47:52 2018 -0500 Commit: Miguel Pellicer <mpellicer@entornosdeformacion.com> CommitDate: Fri Mar 23 10:24:49 2018 +0100
SAM-3275: patch amendment (fail early, avoid at least one DB call)
Issue: Published Copies does not properly check for conflicting gradebook items on Save. If the gradebook has an existing item with the same name as an already-published quiz, and the user modifies quiz settings in Published Copies to enable Send to gradebook, the save completes but the item cannot be sent to the gradebook. The user does not get any warning of this - it's a silent failure. Several instructors at UVA have encountered this issue recently - they don't understand why their quiz grades do not appear in the gradebook after saving the setting to send to gradebook.
In Working Copies, if you try to publish a quiz with the setting Send to gradebook and there is a conflicting gradebook entry, the following error message is displayed instead of publishing:
This should be fixed so the correct error also displays for users on the Published Copies tab.