Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Add Samigo events constants to api to avoid duplication

Description

There was some changes added in for static strings that reference Samigo code. These really should be defined in Samigo and also cleaned up through samigo.

+ public static final String EVENT_PUBASSESSMENT_SETTINGS = "sam.pubsetting.edit";
+ public static final String EVENT_PUBASSESSMENT_UNPUBLISH = "sam.pubassessment.confirm_edit";
+ public static final String EVENT_PUBASSESSMENT_REPUBLISH = "sam.pubassessment.republish";
+ public static final String EVENT_PUBASSESSMENT_REMOVE = "sam.pubAssessment.remove";

There are probably more of these.

Environment

None

Test Plan

None

Activity

Neal Caidin April 25, 2017 at 10:12 AM

Set to won't fix for now. May need to merge later if there are dependencies that need this.

Matthew Jones April 13, 2017 at 12:46 PM
Edited

Probably not without an exhaustive test to verify every event generates correctly. This just might be something we need to merge as it could block merging other issues. The code has been reviewed and it essentially was a search and replace. is where the event names actually changed. Though I don't even know if it will merge cleanly. I'll just mark verified on it as it was really straightforward.

Neal Caidin April 13, 2017 at 10:06 AM

This sounds like a nice cleanup, but is there any way for QA to verify?

Thanks.

Matthew Jones March 30, 2017 at 1:40 PM

This may not be a clean merge back to 11 as events may have only been added for 12, but I think it should get back to make merging of other dependent issues possible.

Fixed

Details

Assignee

Reporter

Labels

Components

Fix versions

Affects versions

Priority

Created November 17, 2015 at 10:35 AM
Updated April 17, 2018 at 8:17 AM
Resolved March 31, 2017 at 9:05 AM