Non-numeric responses for numeric questions breaks total assessment score

Description

Although there is a catch for non-numeric values to numeric responses (--SAM-1348--), it is still possible to submit non-numeric values if:

  • The assessment is set to layout with the complete assessment on one web page

  • The assessment is timed (e.g. 1 min)

  • The student saves or tries to submit

When this occurs, the total assessment score breaks (in testing this becomes zero).

 

 

Attachments

1
  • 28 Nov 2017, 07:15 AM

Activity

Show:

Raúl Sánchez Vegas February 14, 2019 at 7:22 AM

Stephen Marquard November 28, 2017 at 8:23 AM
Edited

Code analysis and looking at the events suggests that processAction() in sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/delivery/SubmitToGradingActionListener.java is throwing FinFormatException so the assessment is not submitted when the student attempts to do so (because of the validation failure) but also the auto-grading calculation is incorrect.

The Timer Thread submission either does not re-calculate the auto score, or has the same scoring problem as the attempted manual submission.

In cases where this happened in production, the score for each individual part in the assessment was correct, but the total score was less than the sum of the part scores.

Regardless of what happens with the validation, the calculated auto score should always be correct based on the saved question data, and total auto score should always be the same as the sum of the part scores.

Incorporated

Details

Priority

Affects versions

Fix versions

Assignee

Reporter

Created November 28, 2017 at 7:19 AM
Updated February 15, 2019 at 5:08 AM
Resolved February 14, 2019 at 7:22 AM

Flag notifications