When the tool menu is minimised each click on a tool causes the menu to expand and then contract

Description

When the tool menu is minimised each click on a tool causes the menu to expand and then contract. This is down to the minimised state being handle by JS and a cookie, rather than the initial server side render cycle. It would be nicer if we could pass a flag to portal/tool indicating that we want the tools rendering minimised to start with and thus avoiding the glitch entirely. Or, we could push the minimised preference into the user's preferences using ajax and then honour that in the portal render.

100% Done
0

Activity

Show:

Andrea Schmidt November 30, 2017 at 8:23 PM

Tested trunk and 12.0

https://trunk-mysql.nightly.sakaiproject.org
Sakai - 8384de68 - Sakai 13-SNAPSHOT - Server ip-172-31-6-159

https://qa2-us.nightly.sakaiproject.org/
Sakai - 12.0 - QA2 10/16/2017 - Sakai 12.0-QA2 - Server ip-172-31-6-159

Win10: Chrome, MS Edge, FF Quantum

While the menu no longer flies open/collapses again, there were numerous console errors. The errors were different between 12 and trunk, so I created 2 different Jiras.

I tested as a logged-in user and a user not logged in (clicking About, welcome, etc)

I don't think the console errors have anything to do with the menu, but a dev should take a look and make that decision. If they're not related to the menu, then this JIRA has been verified on both 12.0 and trunk.

Jiras: SAK-33670, https://sakaiproject.atlassian.net/browse/SAK-33671#icft=SAK-33671

Brian J. August 8, 2017 at 10:33 AM

This will not be able to be merged to 11 unless https://sakaiproject.atlassian.net/browse/SAK-31615#icft=SAK-31615 is also merged to 11, as it changes markup, etc. https://sakaiproject.atlassian.net/browse/SAK-31615#icft=SAK-31615 is currently not marked for merge to 11.

https://sakaiproject.atlassian.net/browse/SAK-32687#icft=SAK-32687 may also need to be merged to 11 if this and the above mentioned ticket are merged.

Matthew Jones July 28, 2017 at 4:15 PM
Edited

There's an error with this one if you're not logged in, it gives javascript errors, will put in a new PR

"toolsCollapsed": ${toolsCollapsed},

Gnapika Reddy Kudumula July 13, 2017 at 2:10 PM

Tested the issue on https://trunk-mysql.nightly.sakaiproject.org/portal/, the issue is fixed

Laura Gekeler April 3, 2017 at 1:09 PM

Steps to Replicate

1) Collapse the lefthand menu
2) Select a tool
3) Do something in the tool
4) Watch the collapsed lefthand menu flash open and then collapsed again.

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Created March 28, 2017 at 4:09 AM
Updated November 30, 2017 at 8:23 PM
Resolved June 20, 2017 at 3:06 PM

Flag notifications