Hibernate 4 getHIbernateTemplate.find and positional parameters

Description

Springs getHibernateTemplate().find() does not work correctly with Hibernate 4 ordinal parameters.

Since ordinal parameters are deprecated in Hibernate the strategy is just to switch away from using them all together.

So we switch getHibernateTemplate().find() to getHibernateTemplate().findByNamedParam() and update the query to use named parameters vs ordinal parameters. While in https://sakaiproject.atlassian.net/browse/KNL-945#icft=KNL-945 this was the practice a few were missed, hence this PR!

After this fix there are only 11 uses of using getHibernateTemplate().find() which are not using any parameters:

samigo/samigo-services/src/java/org/sakaiproject/tool/assessment/facade/AssessmentFacadeQueries.java:2 samigo/samigo-services/src/java/org/sakaiproject/tool/assessment/facade/authz/integrated/AuthzQueriesFacade.java:1 samigo/samigo-services/src/java/org/sakaiproject/tool/assessment/facade/ItemFacadeQueries.java:1 samigo/samigo-services/src/java/org/sakaiproject/tool/assessment/facade/PublishedAssessmentFacadeQueries.java:3 samigo/samigo-services/src/java/org/sakaiproject/tool/assessment/facade/QuestionPoolFacadeQueries.java:3 samigo/samigo-services/src/java/org/sakaiproject/tool/assessment/facade/TypeFacadeQueries.java:1
0% Done
0

relates to

Activity

Show:
Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Created February 22, 2017 at 5:26 PM
Updated February 23, 2017 at 9:49 AM
Resolved February 23, 2017 at 9:49 AM

Flag notifications