We have some sites that have sites manually created that are short like 5 digits
/portal/site/12345
It seems like when you mark them as a favorite with the star they get saved to the database, but when they're retrieved the star doesn't appear.
SAKAI_PREFERENCES after saving a favorite, the last favorite MTIzNDU= is this 12345.
When portal/favorites/list?_=1471964562671 is called it returns all of the sites correctly 37c4f47d-36d5-4c1d-bec8-dc6c0fe8dc6f;d0e2ed68-81ba-4d23-b538-95cfc258b682;12345 but it stlil doesn't star the site 12345.
So my guess is that the bug is in sakai.morpheus.more.sites.js but I'm not seeing it in a quick review.
No errors in logs, no console errors in Chrome or Edge. There is an xml parsing error in Firefox ().
Mark Triggs December 23, 2018 at 1:46 PM
Ah, sorry, I'd totally missed that this was assigned to me, so I just jumped on it when I saw yesterday's notification
Matthew Jones December 23, 2018 at 8:48 AM
Heh, after 2 years of no activity I did a PR for this one too. I'll close mine and review yours. It looks like we did nearly the same thing in the backend for this solution.
Mark Triggs December 22, 2018 at 9:14 PM
I've sent a PR to address this.
Matthew Jones December 22, 2018 at 1:01 PM
This is still an issue on 20.0. This looks like the exception. It might not be "non-GUID" style but seems like from the exception all numeric ids?
We have some sites that have sites manually created that are short like 5 digits
/portal/site/12345
It seems like when you mark them as a favorite with the star they get saved to the database, but when they're retrieved the star doesn't appear.
SAKAI_PREFERENCES after saving a favorite, the last favorite MTIzNDU= is this 12345.
When portal/favorites/list?_=1471964562671 is called it returns all of the sites correctly
37c4f47d-36d5-4c1d-bec8-dc6c0fe8dc6f;d0e2ed68-81ba-4d23-b538-95cfc258b682;12345 but it stlil doesn't star the site 12345.
So my guess is that the bug is in sakai.morpheus.more.sites.js but I'm not seeing it in a quick review.