Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Membership -> My Current Sites: search box and buttons should be right aligned on the page

Description

https://docs.google.com/document/d/1p852qdjT4dpT7aYwZf8dsyJfWN6u4CZlql6LC1yYHOY/edit?pref=2&pli=1

Membership-1: search box and buttons should be right aligned instead of left aligned

Environment

None

Test Plan

Reproduce the issue on : https://qa11-mysql.nightly.sakaiproject.org/ (Safari 9.1)

Compare with fixed version on https://trunk-mysql.nightly.sakaiproject.org/portal/ (Windows 7/Firefox)

Activity

Show:

Molly Kelsey March 26, 2016 at 1:58 PM
Edited

https://trunk-mysql.nightly.sakaiproject.org/portal/
OS X Yosemite v10.10.5
Firefox v45.0.1

Tested, buttons and search bar are left aligned on the page. Spacing between search bar, Search and Clear buttons looks the same, including tablet view.

https://www.evernote.com/l/AsvlLovvtJ1GfrfveqK-ny6RrCeLYjizbtg

Brian J. March 24, 2016 at 1:49 PM
Edited

2nd PR has been merged. Feel free to test again, it should be deployed to the nightlies early tomorrow morning. Spacing between the textbox and the search button should now appear the same as the spacing between the search and clear buttons.

Laura Gekeler March 24, 2016 at 12:54 PM

Let's improve! When will we get the chance again? ~LG

Brian J. March 24, 2016 at 11:33 AM
Edited

Thanks , if you're satisfied can you please set this ticket to 'Verified' ("Tested" button). If you think it's necessary to add some space between the textbox and the search button, I'll issue another PR.

Laura Gekeler March 24, 2016 at 11:28 AM

Here's Safari in a tablet size. Rendering is consistent with Firefox (so: good),yet same issues for improvement as Firefox: http://www.screencast.com/t/GdJ7Q3Zv9fI

Fixed

Details

Assignee

Reporter

Labels

Components

Fix versions

Affects versions

Priority

Created March 23, 2016 at 9:57 AM
Updated March 28, 2016 at 4:09 PM
Resolved March 23, 2016 at 1:34 PM
Configure