Publish sites based in terms. Query is not returning all the expected sites.

GENERAL

TESTING

GENERAL

TESTING

Description

The changes to make lighter the job trying to retrieve only the list of ID's where using the siteService.getSiteIds. Seems that this call is not returning all the expected site Id:

1) The "admin" user must be enrolled in the site for it to be picked up because of this code in DbSiteService:

if ((type == SelectionType.ACCESS) || (type == SelectionType.UPDATE) || (type == SelectionType.MEMBER) || (type == SelectionType.DELETED) || (type == SelectionType.PUBVIEW) || (type == SelectionType.INACTIVE_ONLY)) {
// join with the SITE_USER table
join = siteServiceSql.getSitesJoin1Sql();
}

2) The query only asks for sites that have PUBVIEW=1 ....

It is needed to search for a way to retrieve all the expected sites.

I will work on that.

Linked issues

is related to

SAK-29952

Publish and unpublish courses based in Terms dates.

Activity

Show:

Diego del Blanco Orobitg February 4, 2016 at 3:47 PM

Changed the old branch to https://github.com/ddelblanco/sakai/tree/SAK-30309-NotUserName just in case we want to return to it (because it is working, and it really uses a lot less processing) and let's try the post-filter solution.

Diego del Blanco Orobitg February 3, 2016 at 11:41 AM

Yes, it is. Ive done these changes yet and it works... but a little scared about the function working in all the possible uses and filters... so maybe better to forget this and do the post-filter.

I'll work on that.

Diego del Blanco Orobitg February 3, 2016 at 11:39 AM

This is mostly the code I've changed
https://github.com/sakaiproject/sakai/compare/master...ddelblanco:SAK-30309

Sam Ottenhoff February 3, 2016 at 9:53 AM

Post-filtering will be way easier to implement

Diego del Blanco Orobitg February 3, 2016 at 9:52 AM

I'll try with that. I was trying to restrict the search to only published (or unpublished) sites and in that way it was not needed to post-filter but maybe I can't avoid that.

I was creating a "public List<String> getSiteIdsNotFilteredByUser" that works with any filter but returns all the sites and not the user ones, and added an ACTIVE extra filter. It is almost finished... What do you think is more interesting? To have this new option in the site service, or try to not touch the service and post-filter the results in the job?