Sakai build fails on windows when 'default.sakai.properties' file is edited

Description

The current (SHA: 3f5179077954c2da3c5fae5261263369798ca84a) master version of Sakai fails to build on Windows with the error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-resources-plugin:2.7:resources (default-resources) on project configuration-bundles: Mark invalid -> [Help 1]

Attachments

1
  • 16 Oct 2015, 06:17 AM

Activity

Show:

Matthew Buckett October 16, 2015 at 8:31 AM

This was only happening on windows. Building on linux/mac was working fine. We're already on the latest version of the maven-resource-plugin so upgrading that wasn't possible. One fix was to escape all the @ in the file, but this may well have resulted in the bug appearing again as unescaped @ characters were introduced. The simplest fix seemed to be to stop @ being available as an substitution character.

We did track down the SHA of the change that started presenting this bug was: 15e369dde847dfb98afc32e744bcd2bc55f6af39

Matthew Buckett October 16, 2015 at 8:28 AM

The stack trace being see from maven was:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-resources-plugin:2.7:resources (default-resources) on project configuration-bundles: Mark invalid -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-resources-plugin:2.7:resources (default-resources) on project configuration-bundles: Mark invalid at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106) at org.apache.maven.cli.MavenCli.execute(MavenCli.java:862) at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:286) at org.apache.maven.cli.MavenCli.main(MavenCli.java:197) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:497) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289) at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415) at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356) Caused by: org.apache.maven.plugin.MojoExecutionException: Mark invalid at org.apache.maven.plugin.resources.ResourcesMojo.execute(ResourcesMojo.java:306) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 20 more Caused by: org.apache.maven.shared.filtering.MavenFilteringException: Mark invalid at org.apache.maven.shared.filtering.DefaultMavenFileFilter.copyFile(DefaultMavenFileFilter.java:129) at org.apache.maven.shared.filtering.DefaultMavenResourcesFiltering.filterResources(DefaultMavenResourcesFiltering.java:264) at org.apache.maven.plugin.resources.ResourcesMojo.execute(ResourcesMojo.java:300) ... 22 more Caused by: java.io.IOException: Mark invalid at java.io.BufferedReader.reset(BufferedReader.java:512) at org.apache.maven.shared.filtering.MultiDelimiterInterpolatorFilterReaderLineEnding.read(MultiDelimiterInterpolatorFilterReaderLineEnding.java:416) at org.apache.maven.shared.filtering.MultiDelimiterInterpolatorFilterReaderLineEnding.read(MultiDelimiterInterpolatorFilterReaderLineEnding.java:205) at java.io.Reader.read(Reader.java:140) at org.apache.maven.shared.utils.io.IOUtil.copy(IOUtil.java:181) at org.apache.maven.shared.utils.io.IOUtil.copy(IOUtil.java:168) at org.apache.maven.shared.utils.io.FileUtils.copyFile(FileUtils.java:1856) at org.apache.maven.shared.utils.io.FileUtils.copyFile(FileUtils.java:1804) at org.apache.maven.shared.filtering.DefaultMavenFileFilter.copyFile(DefaultMavenFileFilter.java:114) ... 24 more
Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Environment

windows
Created October 16, 2015 at 6:17 AM
Updated October 16, 2015 at 8:46 AM
Resolved October 16, 2015 at 8:45 AM

Flag notifications