Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

org.sakaiproject.portal.util.ToolUtils.isInlineRequest() fails when passed a ActiveToolComponent$MyActiveTool$WrappedRequest

Description

This portal library code to detect if a request is inline:

org.sakaiproject.portal.util.ToolUtils.isInlineRequest()

Fails when passed a ActiveToolComponent$MyActiveTool$WrappedRequest since the wrapped request messes with the getPathInfo() method.

So the better choice is to go to getRequestURI() instead which is dutifly passed through a WrappedRequest.

Activity

Show:

Hudson CI Server December 1, 2014 at 8:20 PM

SUCCESS: Integrated in sakai-10-java-1.7 #150 (See http://builds.sakaiproject.org:8080/job/sakai-10-java-1.7/150/)
https://sakaiproject.atlassian.net/browse/SAK-28146#icft=SAK-28146 reverse merge 315760 from 10.x (enietzel@anisakai.com: rev 315821)
https://sakaiproject.atlassian.net/browse/SAK-28146#icft=SAK-28146 merge 315760 from trunk (enietzel@anisakai.com: rev 315805)

Charles R Severance December 1, 2014 at 2:21 PM

OK - Coool - thanks.

Earle Nietzel December 1, 2014 at 2:17 PM

This has dependency which is not scheduled for 10, SAK-27774.

Charles R Severance December 1, 2014 at 11:53 AM

Thanks Earle.

Hudson CI Server November 30, 2014 at 1:18 AM

SUCCESS: Integrated in sakai-trunk-java-1.7 #538 (See http://builds.sakaiproject.org:8080/job/sakai-trunk-java-1.7/538/)
https://sakaiproject.atlassian.net/browse/SAK-28146#icft=SAK-28146

Fix a problem where ActiveToolComponent$MyActiveTool$WrappedRequest
does not proxy getPathInfo() properly so we look at getRequestURI()
to parse the path. (csev@umich.edu: rev 315760)

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Created November 29, 2014 at 12:58 PM
Updated February 18, 2016 at 4:43 PM
Resolved November 30, 2014 at 1:17 PM

Flag notifications