Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

file helper import doesn't work

Description

FilePickerAction:doAttachItem has been modified to only work if the request is a POST. Unfortunately the UI for the file picker uses a GET when you select an item from the list in resources. Please either fix the UI or remove the if (!"POST".equals(data.getRequest().getMethod())) { at the beginning of doAttachItem.

This affects at least Assignment and OSP, but probably others.

100% Done
Loading...

Activity

Show:

Charles Hedrick March 10, 2015 at 1:40 PM

I've added a PR that changes the UI to generate a POST.

Charles Hedrick March 9, 2015 at 10:27 AM

I recommend against removing the test for post. That is going to make security issues very hard to address. I'll look at fixing it to use POST.

Matthew Jones March 5, 2015 at 10:01 AM

It seems like the fastest fix would be to remove the POST protection. It would be nice if this page submitted via POST but that might take some more work? If the fix to remove the protection is added a new jira should be created.

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Labels

Created November 25, 2014 at 8:43 AM
Updated 3 days ago
Resolved March 17, 2015 at 8:20 AM