Sakai help system uses hibernate in a dangerous way

Description

The new help system creates it's own hibernate session factory (which is probably not a great idea) and also depends on creating a new CacheManager and cache for holding L2 results BUT shares the other 2 hibernate caches with the rest of Sakai.

Probably the best solution here is to not create a separate hibernate SessionManager but the stopgap solution is to just use the existing cacheProvider (org.sakaiproject.springframework.orm.hibernate.SakaiCacheProvider) rather than recreating a new one.

components/sakai-comp-help/WEB-INF/components.xml]: Cannot resolve reference to bean 'helpSessionFactory' while setting bean property 'sessionFactory'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'helpSessionFactory' defined in file /opt/tomcat-trunk/components/sakai-comp-help/WEB-INF/components.xml: Cannot create inner bean 'org.sakaiproject.springframework.orm.hibernate.SakaiCacheProvider#749cd006' of type [org.sakaiproject.springframework.orm.hibernate.SakaiCacheProvider] while setting bean property 'cacheProvider'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.sakaiproject.springframework.orm.hibernate.SakaiCacheProvider#749cd006' defined in file /opt/tomcat-trunk/components/sakai-comp-help/WEB-INF/components.xml: Cannot resolve reference to bean 'org.sakaiproject.springframework.orm.hibernate.L2Cache' while setting bean property 'defaultCache'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No bean named 'org.sakaiproject.springframework.orm.hibernate.L2Cache' is defined

Attachments

2
  • 15 Apr 2014, 05:38 PM
  • 15 Apr 2014, 01:19 PM

Activity

Show:

Neal Caidin May 2, 2014 at 8:12 AM

I've been testing the new Help content and things look fine. Calling this one as tested.

Hudson CI Server April 18, 2014 at 6:08 AM

Integrated in sakai-trunk-java-1.7 #192 (See http://builds.sakaiproject.org:8080/job/sakai-trunk-java-1.7/192/)

Result = SUCCESS

Sam Ottenhoff April 16, 2014 at 1:14 PM

Yes, a regression test is fine. The change looks okay to me.

Neal Caidin April 16, 2014 at 6:38 AM

Is the Test Plan to perform a regression test on the Help system?

Matthew Jones April 15, 2014 at 6:22 PM
Edited

This isn't actually related to SAK-26054, this was introduced before in https://sakaiproject.atlassian.net/browse/SAK-22819#icft=SAK-22819

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Created April 15, 2014 at 1:10 PM
Updated July 1, 2014 at 7:44 AM
Resolved April 15, 2014 at 5:39 PM

Flag notifications