Target=" _blank" no matter what the user chooses

Description

Rich text editor only saves target="_blank", no matter what the user chooses when adding a URL and setting the properties. This was fixed in KNL-526, but obviously is not fixed in 2.9.1 or 2.9.x

To reproduce:
Click on Announcements (or any other tool that uses the rich text editor), and click Add
In the rich text box, click on the URL icon and add a URL
Click on the Target tab and change the target
Click OK
Post the Announcement

Click on Home in the menu, then view the announcement
Click the link - it opens in a new tab/window no matter what you chose

View the source for that frame and you will see target="_blank"

Environment

https://qa29.longsight.com/ TRUNK - Sakai 2.9.1 (Kernel 1.3.1)- Server localhost http://nightly2.sakaiproject.org:8087/portal 2.9.x on HSQLDB - Built: 03/14/13 01:00 - Sakai sakai-2.9.x-all (Kernel 1.3-SNAPSHOT)- Server localhost

Test Plan

None

Attachments

2

Activity

Matthew Jones April 24, 2018 at 10:35 AM

Bulk closing issues that have not been updated since 2015 and earlier. Please reopen if this is still an issue and you have new information or if this is a feature you'd like to still have consideration for.

Oliver Williams April 24, 2013 at 7:22 AM
Edited

Added and linked to Sakai CLE 2.9.2-rc01 Testing Jira as

Oliver Williams April 23, 2013 at 9:17 AM
Edited

Tested on https://qa29.longsight.com/portal

I picked up an issue with two of the link targets in all the tools listed in the test script, with the exception of 'Resources - HTML page' which works as expected, where the target is being reset to (_blank) after Post / Save for <not set> and <popup window> - so CK Editor looks like it has saved your selection after clicking OK, but when you save and then Edit again, the target has changed:
<not set> resets to (_blank)
<popup window> resets to (_blank)

See HTML source after the save below:
<p>
<a href="http://www.opencollab.co.za" target="_blank">www.opencollab.co.za</a>&nbsp;not set</p>
<p>
<a href="http://www.opencollab.co.za" target="frame">www.opencollab.co.za</a>&nbsp;frame</p>
<p>
<a href="http://www.opencollab.co.za" target="_blank">www.opencollab.co.za</a>&nbsp;popup window</p>
<p>
<a href="http://www.opencollab.co.za" target="_blank">www.opencollab.co.za</a>&nbsp;new window</p>
<p>
<a href="http://www.opencollab.co.za" target="_top">www.opencollab.co.za</a>&nbsp;topmost window</p>
<p>
<a href="http://www.opencollab.co.za" target="_self">www.opencollab.co.za</a>&nbsp;same window</p>
<p>
<a href="http://www.opencollab.co.za" target="_parent">www.opencollab.co.za&nbsp;</a>parent window</p>

Teresa Collins April 1, 2013 at 1:32 PM

This is still a problem on trunk using Firefox 19.0.2 for the following hyperlink targets:
1. _frame / (Target Frame Name)

  • _frame itself works, however if a value is used for the Target Frame Name - errors result.
    2. <popup window> (Popup Window)
    Nothing will work with this type of target.

Matthew Jones March 28, 2013 at 9:22 AM

Closing as duplicate of as patches are being attached there

Won't Fix

Details

Assignee

Reporter

Components

Affects versions

Priority

Created March 14, 2013 at 12:37 PM
Updated April 24, 2018 at 10:35 AM
Resolved April 24, 2018 at 10:35 AM