Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Archive import throws IdUnusedException if site doesnt exist, but creates it anyway

Description

when importing a site archive in the Admin archive tool, if you specify a site that doesnt exist, then it throws an exception in the logs as a warning.

2013-01-30 15:03:28,740 WARN http-8080-Processor20 org.sakaiproject.archive.impl.SiteMerger - org.sakaiproject.exception.IdUnusedException id=blah
org.sakaiproject.exception.IdUnusedException id=blah
at org.sakaiproject.site.impl.BaseSiteService.getDefinedSite(BaseSiteService.java:589)
at org.sakaiproject.site.impl.BaseSiteService.getSite(BaseSiteService.java:672)
at org.sakaiproject.archive.impl.SiteMerger.processMerge(SiteMerger.java:201)
at org.sakaiproject.archive.impl.SiteMerger.merge(SiteMerger.java:152)
at org.sakaiproject.archive.impl.ArchiveService2Impl.merge(ArchiveService2Impl.java:137)
at org.sakaiproject.archive.cover.ArchiveService.merge(ArchiveService.java:71)
at org.sakaiproject.archive.tool.ArchiveAction.doImport(ArchiveAction.java:193)

This makes it look like an error in the import when in fact the site is created just fine. This should be caught and a message saying 'Site x doesnt exist, it will be created' or similar.

Activity

Show:

Hudson CI Server January 31, 2013 at 1:07 PM

Integrated in common trunk #537 (See http://builds.sakaiproject.org:8080/job/common%20trunk/537/)
- IdUnusedException unnecessarily thrown. (Revision 119413)

Result = SUCCESS

Matthew Jones January 31, 2013 at 12:54 PM

Fixed in 119413, message changed to an info, removed stacktrace.

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Labels

Created January 29, 2013 at 8:07 PM
Updated June 30, 2014 at 3:35 PM
Resolved January 31, 2013 at 12:54 PM