Default site language option should not be empty

Description

Currently the default option for site language is empty (there is no text in the drop down) This is likely to be confusing for users and should have some descriptive text:

  • Default
    or

  • Default (users language)

Activity

Show:

Hudson CI Server July 25, 2011 at 7:26 AM

Zhen Qian July 25, 2011 at 7:08 AM

r95579 adds back the "User Language(default)" choice.

Joaquín Marqués Alós July 21, 2011 at 3:07 AM

To change the text of the default option (which is now empty), just have to modify this code in chef_site-siteInfo-editInfo.vm:

Original code:

<select name="locales" class="indnt2" id="locales" size="5">
#foreach($locale in $locales)
<option value="$locale.toString()" #if ($locale.toString() == $locale_string)selected="true" #elseif($locale.toString() == "")selected="true" #end>
$validator.escapeHtml($locale.getDisplayName())
</option>
#end
</select>

Modified code:

<select name="locales" class="indnt2" id="locales" size="5">
#foreach($locale in $locales)
<option value="$locale.toString()" #if ($locale.toString() == $locale_string)selected="true" #elseif($locale.toString() == "")selected="true" #end>
#if($locale.toString() == "") $tlang.getString("sinfo.defaultUserLanguage") #else $validator.escapeHtml($locale.getDisplayName()) #end
</option>
#end
</select>

Is necessary to add "sinfo.defaultUserLanguage" in sitesetupgeneric.properties.

Diego del Blanco Orobitg July 21, 2011 at 1:02 AM
Edited

The new way of working doesn't allow a site to be "free language" as designed by Samoo in the original feature. There is needed an "USER LENGUAGE" (or default or blank) text in the drop down menu, as descripted in the issue to allow not ot select a fixed language. If you select by default the default language, you fix that language as the only one in the site! The lenguage property of the site must be empty to work correctly when is not defined the language in the tool.

There is need to reopen the issue, please.

Hudson CI Server June 28, 2011 at 10:10 PM

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Created June 27, 2011 at 4:34 AM
Updated November 26, 2012 at 7:28 AM
Resolved July 25, 2011 at 7:08 AM