Be more obsessed about iFrame Resizing

Description

Currently, if a page takes too long to load we end up with scrollbars. Make it so that we double check this using jQuery as well as hook in a resize trigger to re-set the document height when the window is resized.

This may be troublesome if there are other dynamic trigger oriented resize action going on for a particular tool so this needs some significant testing. I think rWiki might have done something like this.

Attachments

2
  • 02 Apr 2011, 12:20 PM
  • 02 Apr 2011, 12:07 PM

Activity

Show:

Charles R Severance December 19, 2011 at 9:00 AM

This was never critical - simply nice to have. It turned out to be harder than expected. If someone wants to work on this - they can open a new JIRA.

Beth Kirschner December 8, 2011 at 8:59 AM

I've reverted this change due to the problems mentioned above

Beth Kirschner December 8, 2011 at 7:46 AM

This issue also introduced accessibility problems (where focus jumps to the top)

Steve Swinsburg December 5, 2011 at 2:47 PM

Profile2 also does it's own iframe resizing as it lazy loads various panels dynamically, so needs to grow or shrink the iframe to suit. I think the iframe resizing should be left to the tools to do.

Beth Kirschner December 5, 2011 at 9:06 AM

This change is causing problems in IE (see https://sakaiproject.atlassian.net/browse/SAK-21212#icft=SAK-21212) – unless these problems can be resolved soon, we should probably revert this change until a better implementation can be designed.

Won't Fix

Details

Priority

Affects versions

Components

Assignee

Reporter

Created April 2, 2011 at 9:35 AM
Updated December 5, 2012 at 6:37 AM
Resolved December 19, 2011 at 9:00 AM