r89272 - Strangely the MySQL conversion script has already been changed to 255. So only adjusted the Oracle one.
Seth Theriault March 3, 2011 at 7:13 AM
I think the "127 or 255" question is for the Gradebook developers/maintainers. Otherwise, I agree that the conversion scripts should be consistent with the HBMs, whatever they need to be.
David Adams March 3, 2011 at 7:07 AM
Makes the most sense to change the conversion scripts to reflect the hibernate/auto.ddl default. Changing anything else risks a cascade of other problems.
When comparing a fresh auto-ddl'd 2.8 beta05 database against an upgraded 2.7.1 database, the following inconsistency was found:
GB_GRADE_RECORD_T.USER_ENTERED_GRADE
2.8 auto.ddl: VARCHAR2(255 CHAR)
2.7.1 converted: VARCHAR2(127 BYTE)
(You can ignore the BYTE/CHAR discrepancy at the moment.)
The relevant entries in the 2.8 conversion scripts is:
– Gradebook2 support
– SAK-19080 /
alter table GB_GRADE_RECORD_T add USER_ENTERED_GRADE varchar2(127);