Membership tool ignores wsetup.disable.unjoin sakai properties
GENERAL
TESTING
GENERAL
TESTING
Description
Attachments
1
- 13 Jan 2011, 04:53 PM
is related to
Activity
Show:
Sam Ottenhoff January 20, 2011 at 1:08 PM
Merged into 2.7.x and 2.8.x. Thanks Bryan and Zhen.
Bryan Bryan January 14, 2011 at 11:14 AM
Zhen, I tested your additional changes on my dev server and everything is working good
Zhen Qian January 13, 2011 at 8:38 PM
r87275.
Thanks for the patch, Bryan. I did some further modification as to not show the disabled checkboxes for the not-unjoinable sites, otherwise those disabled checkboxes toggle states with the top "select all" checkbox selection, which maybe misleading to users.
In Sakai 2.7 the membership tool seems to ignore these sakai properties that were working in Sakai 2.6:
wsetup.disable.unjoin.count=1
wsetup.disable.unjoin.1=course
I believe this is related to: SAK-15142
It looks like the problem is in this file: /site-manage/site-manage-tool/tool/src/webapp/vm/membership/chef_membership.vm
The check to see if you can unjoin a site uses the $siteType variable which is declared below the if statement that uses it. I moved the variable declaration back above the if statement where it used to be and everything works again. Since I'm not good at explaining things I have attached the diff of the code that is working for me.