Bulk closing issues that have not been updated since 2015 and earlier. Please reopen if this is still an issue and you have new information or if this is a feature you'd like to still have consideration for.

For those looking the magic file is: config/localization/bundles/src/bundle/org/sakaiproject/localization/bundle/tool/tools.properties

My concern with this change is that tools are no longer very self contained. To get an i18n supported tool name your contrib tool has to update files in the core of Sakai which seems a little broken. Ah, ok, so you can put properties files in the webapp/tools folder and these get loaded for a tool.

As a side note we had tool names that had changed locally in 2.4, these continued to work in 2.6 but now in 2.8 it's broken. This doesn't make upgrading very easy.

Looking back through the Jira's I don't seem much discussion about why this route was taken, was embedding i18n titles/descriptions in the tool registration file ruled out?

I see what you're saying Nicola, the only (easy) way to change tool names now locally is with the tools.properties file. As after to Tool.java the logic changed from:

if tool.title is defined in tools.properties
return this tool.title
else
return the tool.title in the tool registration file

– TO –

if tool.title is for this tool.id defined in tool.properties
return this title
else
if tool.title is defined in users locale bundle
return this title
if tool.name is defined in DEFAULT local bundle
return this title
return the tool.title in the tool registration file //Will never get here unless you the tool isn't defined in the bundles.

It feels like this should be marked as a won't fix with the appropriate documentation on how to override it. I know you can do it by modifying the tools.properties in the config tool (a pretty easy change) or possibly in 2.9 from the database with KNL-563.

Matthew -

I know it's been a while, but I was just looking at this ticket anew, and I must admit some confusion. Yes, I can see the benefit of Tania's patch for what she needs, but it doesn't seem to solve the issue in this JIRA, which is that Sakai no longer respects the tool registration file when it comes to determining the name of the tool (regardless of where that file may live). Don't hesitate to let me know if I've misunderstood your suggestion of how this patch could help mitigate the extra steps and overhead now required in renaming tools.

FYI Tania attached patch in that does exactly what I was describing.