Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

OSP Tools don't respect language/locale preferences (only when english is not the default locale) - Part 2

Description

Continuation of work started in SAK-14401. I'm creating a new ticket to better track what is going into the Sakai 2.8 release and what is outstanding.

The following file patches from the SAK-14401_escapeHTML.patch have been moved into the SAK-19184-part-1.patch file

  • presentationTemplate.inc - CR/LF on every line obsfucate the actual changes

  • wizardHeader.inc – incorrect/incomplete changes (use of fmt:param elements which need to be resolved)

  • wizardFooter.inc – looks good, needs testing

  • comments.inc – looks good, needs testing

The () osp-message patch has been renamed SAK-19184-part-2.patch still needs to be reviewed and applied.

Attachments

5

Activity

Show:

Oliver Williams September 27, 2012 at 4:44 AM
Edited

Great! my pleasure David, I've verified as successfully tested.

David Roldán Martínez September 27, 2012 at 4:36 AM

It's ok on my side! Thanks so much!!!

Oliver Williams September 27, 2012 at 4:32 AM
Edited

Tested in http://nightly2.sakaiproject.org:8082/portal/ using Spanish (Spain) locale

I'm not entirely sure what I am testing tbh! but I added all the OSP tools to a site and switched from default local to Spanish (Spain).

Nothing broke, but some labels were coming through as English rather than Spanish, which might just be a resource bundle key/value pair that is missing? I have attached screenshots of the English imposters. So for example Roles in Site Info and Portfolio Type in Portfolio details - are these expected to be translated?

Let me know if my testing coverage / depth is adequate, and if so, I will verify. If my test coverage falls short, or I am not testing the right thing, then perhaps somebody else can take this one, or provide guidance?

Tania Tritean October 10, 2011 at 6:59 AM

It seems that the version of spring that is used in sakai works a little bit different when searching the resource files
This problem can be solved also by providing properties file for en locale specific.

Hudson CI Server September 20, 2011 at 3:50 PM

Integrated in metaobj trunk #42 (See http://builds.sakaiproject.org:8080/job/metaobj%20trunk/42/)
- Adding copyright notice.

Fixed

Details

Priority

Affects versions

Fix versions

Components

Assignee

Reporter

Labels

Created September 21, 2010 at 11:45 AM
Updated June 18, 2013 at 9:49 AM
Resolved September 20, 2011 at 3:12 PM